Merge #578: Add default impl for Miniscript::num_der_paths

88f7f5b Add default impl or num_der_paths (Tobin C. Harding)

Pull request description:

  The trait method `MiniscriptKey::num_der_paths` often returns 0, lets just make this the default.

ACKs for top commit:
  apoelstra:
    ACK 88f7f5b

Tree-SHA512: 848f06f56a4af57912d64a8e28ee730ff878b06234ffdb2324e104bcab1c9daeff25c938dc3d05714502e8ac4ce47701e85ac34b2ddd4588ae0d305b3a8cb739

Author: apoelstra

src/interpreter/mod.rs

@@ -127,10 +127,6 @@ impl MiniscriptKey for BitcoinKey {
     type Hash256 = hash256::Hash;
     type Ripemd160 = ripemd160::Hash;
     type Hash160 = hash160::Hash;
-
-    fn num_der_paths(&self) -> usize {
-        0
-    }
 }
 
 impl<'txin> Interpreter<'txin> {

src/lib.rs

@@ -166,7 +166,9 @@ pub trait MiniscriptKey: Clone + Eq + Ord + fmt::Debug + fmt::Display + hash::Ha
 
     /// Returns the number of different derivation paths in this key. Only >1 for keys
     /// in BIP389 multipath descriptors.
-    fn num_der_paths(&self) -> usize;
+    fn num_der_paths(&self) -> usize {
+        0
+    }
 
     /// The associated [`bitcoin::hashes::sha256::Hash`] for this [`MiniscriptKey`], used in the
     /// sha256 fragment.
@@ -190,10 +192,6 @@ impl MiniscriptKey for bitcoin::secp256k1::PublicKey {
     type Hash256 = hash256::Hash;
     type Ripemd160 = ripemd160::Hash;
     type Hash160 = hash160::Hash;
-
-    fn num_der_paths(&self) -> usize {
-        0
-    }
 }
 
 impl MiniscriptKey for bitcoin::PublicKey {
@@ -202,10 +200,6 @@ impl MiniscriptKey for bitcoin::PublicKey {
         !self.compressed
     }
 
-    fn num_der_paths(&self) -> usize {
-        0
-    }
-
     type Sha256 = sha256::Hash;
     type Hash256 = hash256::Hash;
     type Ripemd160 = ripemd160::Hash;
@@ -221,21 +215,13 @@ impl MiniscriptKey for bitcoin::secp256k1::XOnlyPublicKey {
     fn is_x_only_key(&self) -> bool {
         true
     }
-
-    fn num_der_paths(&self) -> usize {
-        0
-    }
 }
 
 impl MiniscriptKey for String {
     type Sha256 = String; // specify hashes as string
     type Hash256 = String;
     type Ripemd160 = String;
     type Hash160 = String;
-
-    fn num_der_paths(&self) -> usize {
-        0
-    }
 }
 
 /// Trait describing public key types which can be converted to bitcoin pubkeys