Merge #697: plan: make LoggerAssetProvider constructible

c79639d clippy: fix doc indentation (Andrew Poelstra)
b39b707 plan: make LoggerAssetProvider constructible (Andrew Poelstra)

Pull request description:

  It looks like we have an example AssetProvider that is intended to be used for testing/debugging. It looks useful but evidently has never been used because it was impossible to construct.

  Recent versions of rust nightly notice this and output a warning about this, which is causing CI to fail, so we need to fix it.

  My solution is to make the inner `Assets` public (and also a reference, since there is no need to take ownership) so that people can easily construct and deconstruct the type.

ACKs for top commit:
  tcharding:
    ACK c79639d
  sanket1729:
    ACK c79639d

Tree-SHA512: c19e00c88f79edd7b99632470b556385a36ba59112d8015222321581f87d0110f155fc725bfc05187201fc7a3845998427887852d09bda0e20354570de4b7e8e

Author: apoelstra

src/lib.rs

@@ -344,7 +344,7 @@ impl<E> TranslateErr<E> {
     /// - SegwitV0 does not allow uncompressed keys and x_only keys
     /// - Tapscript does not allow uncompressed keys
     /// - Translating into multi-path descriptors should have same number of path
-    /// for all the keys in the descriptor
+    ///   for all the keys in the descriptor
     ///
     /// # Panics
     ///

src/plan.rs

@@ -108,7 +108,7 @@ pub trait AssetProvider<Pk: MiniscriptKey> {
 
 /// Wrapper around [`Assets`] that logs every query and value returned
 #[cfg(feature = "std")]
-pub struct LoggerAssetProvider(Assets);
+pub struct LoggerAssetProvider<'a>(pub &'a Assets);
 
 #[cfg(feature = "std")]
 macro_rules! impl_log_method {
@@ -123,7 +123,7 @@ macro_rules! impl_log_method {
 }
 
 #[cfg(feature = "std")]
-impl AssetProvider<DefiniteDescriptorKey> for LoggerAssetProvider {
+impl<'a> AssetProvider<DefiniteDescriptorKey> for LoggerAssetProvider<'a> {
     impl_log_method!(provider_lookup_ecdsa_sig, pk: &DefiniteDescriptorKey, -> bool);
     impl_log_method!(provider_lookup_tap_key_spend_sig, pk: &DefiniteDescriptorKey, -> Option<usize>);
     impl_log_method!(provider_lookup_tap_leaf_script_sig, pk: &DefiniteDescriptorKey, leaf_hash: &TapLeafHash, -> Option<usize>);