Remove deprecated secp.sign_ecdsa

Author: tcharding

bitcoind-tests/tests/test_cpp.rs

@@ -173,7 +173,7 @@ pub fn test_from_cpp_ms(cl: &Client, testdata: &TestData) {
 
         // Finally construct the signature and add to psbt
         for sk in sks_reqd {
-            let signature = secp.sign_ecdsa(&msg, &sk);
+            let signature = secp256k1::ecdsa::sign(&msg, &sk);
             let pk = pks[sks.iter().position(|&x| x == sk).unwrap()];
             psbts[i].inputs[0]
                 .partial_sigs

bitcoind-tests/tests/test_desc.rs

@@ -252,7 +252,7 @@ pub fn test_desc_satisfy(
 
             // Finally construct the signature and add to psbt
             for sk in sks_reqd {
-                let signature = secp.sign_ecdsa(&msg, &sk);
+                let signature = secp256k1::ecdsa::sign(&msg, &sk);
                 let pk = pks[sks.iter().position(|&x| x == sk).unwrap()];
                 assert!(secp.verify_ecdsa(&msg, &signature, &pk.inner).is_ok());
                 psbt.inputs[0]

examples/psbt_sign_finalize.rs

@@ -126,12 +126,12 @@ fn main() {
     let sk2 = backup2_private.inner;
 
     // Finally construct the signature and add to psbt
-    let sig1 = secp256k1.sign_ecdsa(msg, &sk1);
+    let sig1 = secp256k1::ecdsa::sign(msg, &sk1);
     let pk1 = backup1_private.public_key();
     assert!(secp256k1.verify_ecdsa(msg, &sig1, &pk1.inner).is_ok());
 
     // Second key just in case
-    let sig2 = secp256k1.sign_ecdsa(msg, &sk2);
+    let sig2 = secp256k1::ecdsa::sign(msg, &sk2);
     let pk2 = backup2_private.public_key();
     assert!(secp256k1.verify_ecdsa(msg, &sig2, &pk2.inner).is_ok());
 

src/descriptor/mod.rs

@@ -1379,7 +1379,7 @@ mod tests {
         let msg = secp256k1::Message::from_digest(
             *b"michael was a message, amusingly",
         );
-        let sig = secp.sign_ecdsa(msg, &sk);
+        let sig = secp256k1::ecdsa::sign(msg, &sk);
         let mut sigser = sig.serialize_der().to_vec();
         sigser.push(0x01); // sighash_all
 

src/policy/compiler.rs

@@ -1257,7 +1257,7 @@ mod tests {
             };
             ret.push(pk);
         }
-        let sig = secp.sign_ecdsa(
+        let sig = secp256k1::ecdsa::sign(
             secp256k1::Message::from_digest(sk), // Not a digest but 32 bytes nonetheless.
             &secp256k1::SecretKey::from_secret_bytes(sk).expect("secret key"),
         );