WIP: Add support for Bitcoin Core v28

Add support and testing for Bitcoin Core versions `28.0`

Author: tnull

.github/workflows/rust.yaml

@@ -178,6 +178,7 @@ jobs:
       matrix:
         feature:
           [
+            "28_0",
             "27_1",
             "27_0",
             "26_2",

client/src/client_sync/v28.rs

@@ -0,0 +1,44 @@
+// SPDX-License-Identifier: CC0-1.0
+
+//! A JSON-RPC client for testing against Bitcoin Core `v27`.
+//!
+//! We ignore option arguments unless they effect the shape of the returned JSON data.
+
+use bitcoin::address::{Address, NetworkChecked};
+use bitcoin::{Amount, Block, BlockHash, Txid};
+
+use crate::client_sync::{handle_defaults, into_json};
+use crate::json::v28::*;
+
+crate::define_jsonrpc_minreq_client!("v27");
+
+// == Blockchain ==
+crate::impl_client_v17__getblockchaininfo!();
+crate::impl_client_v17__getbestblockhash!();
+crate::impl_client_v17__getblock!();
+crate::impl_client_v17__gettxout!();
+
+// == Control ==
+crate::impl_client_v17__stop!();
+
+// == Generating ==
+crate::impl_client_v17__generatetoaddress!();
+
+// == Network ==
+crate::impl_client_v17__getnetworkinfo!();
+crate::impl_client_check_expected_server_version!({ [270000, 270100] });
+
+// == Rawtransactions ==
+crate::impl_client_v17__sendrawtransaction!();
+
+// == Wallet ==
+crate::impl_client_v17__createwallet!();
+crate::impl_client_v22__unloadwallet!();
+crate::impl_client_v22__loadwallet!();
+crate::impl_client_v17__getbalance!();
+crate::impl_client_v19__getbalances!();
+crate::impl_client_v17__getnewaddress!();
+crate::impl_client_v17__sendtoaddress!();
+crate::impl_client_v17__gettransaction!();
+
+pub use crate::client_sync::v23::AddressType;

contrib/run_bitcoind.sh

@@ -23,6 +23,7 @@ COMMAND
    - stop                     Kill all bitcoind nodes using 'pkill bitcoind'.
 
 KNOWN_VERSION
+   - v28                Bitcoin Core v28.0
    - v27                Bitcoin Core v27.1
    - v26                Bitcoin Core v26.2
    - v25                Bitcoin Core v25.2
@@ -49,6 +50,7 @@ main() {
 
     case $cmd in
         all)
+            start "v28"         # 28.0
             start "v27"         # 27.1
             start "v26"         # 26.2
             start "v25"         # 25.2
@@ -84,6 +86,11 @@ start() {
     local version="$1"
 
     case $version in
+        v28)
+            local version_number="28.0"
+            local version_id="280"
+            ;;
+
         v27)
             local version_number="27.1"
             local version_id="271"

integration_test/Cargo.toml

@@ -13,6 +13,7 @@ edition = "2021"
 [features]
 # Enable the same feature in `bitcoind` and the version feature here.
 # All minor releases (but only the latest patch release).
+"28_0" = ["v28", "bitcoind/28_0"]
 "27_1" = ["v27", "bitcoind/27_1"]
 "27_0" = ["v27", "bitcoind/27_0"]
 "26_2" = ["v26", "bitcoind/26_2"]
@@ -37,6 +38,7 @@ edition = "2021"
 "0_17_1" = ["v17", "bitcoind/0_17_1"]
 
 # Each minor version is tested with the same client.
+"v28" = []
 "v27" = []
 "v26" = []
 "v25" = []

integration_test/tests/v28_api.rs

@@ -0,0 +1,57 @@
+//! Test the JSON-RPC API against `bitcoind v28.0`.
+
+#![cfg(feature = "v28")]
+
+use integration_test::*;
+
+// == Blockchain ==
+mod blockchain {
+    use super::*;
+
+    impl_test_v17__getblockchaininfo!();
+    impl_test_v17__getbestblockhash!();
+    impl_test_v17__getblock_verbosity_0!();
+    impl_test_v17__getblock_verbosity_1!();
+}
+
+// == Control ==
+mod control {
+    use super::*;
+
+    impl_test_v17__stop!();
+}
+
+// == Generating ==
+mod generating {
+    use super::*;
+
+    impl_test_v17__generatetoaddress!();
+}
+
+// == Network ==
+mod network {
+    use super::*;
+
+    impl_test_v17__getnetworkinfo!();
+}
+
+// == Rawtransactions ==
+mod raw_transactions {
+    use super::*;
+
+    impl_test_v17__sendrawtransaction!();
+}
+
+// == Wallet ==
+mod wallet {
+    use super::*;
+
+    impl_test_v17__createwallet!();
+    impl_test_v17__loadwallet!();
+
+    impl_test_v17__getnewaddress!();
+    impl_test_v17__getbalance!();
+    impl_test_v19__getbalances!();
+    impl_test_v17__sendtoaddress!();
+    impl_test_v17__gettransaction!();
+}

json/src/lib.rs

@@ -19,6 +19,7 @@ pub mod v24;
 pub mod v25;
 pub mod v26;
 pub mod v27;
+pub mod v28;
 
 // JSON types that model _all_ `bitcoind` versions.
 pub mod model;

json/src/v17/blockchain.rs

@@ -201,8 +201,9 @@ impl fmt::Display for GetBlockchainInfoError {
 
         match *self {
             Chain(ref e) => write_err!(f, "conversion of the `chain` field failed"; e),
-            BestBlockHash(ref e) =>
-                write_err!(f, "conversion of the `best_block_hash` field failed"; e),
+            BestBlockHash(ref e) => {
+                write_err!(f, "conversion of the `best_block_hash` field failed"; e)
+            }
             ChainWork(ref e) => write_err!(f, "conversion of the `chain_work` field failed"; e),
         }
     }
@@ -369,10 +370,12 @@ impl fmt::Display for GetBlockVerbosityOneError {
             Tx(ref e) => write_err!(f, "conversion of the `tx` field failed"; e),
             Bits(ref e) => write_err!(f, "conversion of the `bits` field failed"; e),
             ChainWork(ref e) => write_err!(f, "conversion of the `chain_ork` field failed"; e),
-            PreviousBlockHash(ref e) =>
-                write_err!(f, "conversion of the `previous_block_hash` field failed"; e),
-            NextBlockHash(ref e) =>
-                write_err!(f, "conversion of the `next_block_hash` field failed"; e),
+            PreviousBlockHash(ref e) => {
+                write_err!(f, "conversion of the `previous_block_hash` field failed"; e)
+            }
+            NextBlockHash(ref e) => {
+                write_err!(f, "conversion of the `next_block_hash` field failed"; e)
+            }
         }
     }
 }
@@ -481,8 +484,9 @@ impl fmt::Display for GetTxOutError {
         match *self {
             BestBlock(ref e) => write_err!(f, "conversion of the `best_block` field failed"; e),
             Value(ref e) => write_err!(f, "conversion of the `value` field failed"; e),
-            ScriptPubkey(ref e) =>
-                write_err!(f, "conversion of the `script_pubkey` field failed"; e),
+            ScriptPubkey(ref e) => {
+                write_err!(f, "conversion of the `script_pubkey` field failed"; e)
+            }
             Address(ref e) => write_err!(f, "conversion of the `address` field failed"; e),
         }
     }

json/src/v17/network.rs

@@ -155,8 +155,9 @@ impl fmt::Display for GetNetworkInfoError {
 
         match *self {
             RelayFee(ref e) => write_err!(f, "conversion of the `relay_fee` field failed"; e),
-            IncrementalFee(ref e) =>
-                write_err!(f, "conversion of the `incremental_fee` field failed"; e),
+            IncrementalFee(ref e) => {
+                write_err!(f, "conversion of the `incremental_fee` field failed"; e)
+            }
         }
     }
 }