Merge #139: Improve errors

c89065d Make struct error internals public (Tobin C. Harding)
ac24f23 Remove unused error types (Tobin C. Harding)

Pull request description:

  Audit all error types as per discussion in rust-bitcoin/rust-bitcoin#820

  I believe with these patches applied we are good to go for v1.0 in regards to error handling.

ACKs for top commit:
  apoelstra:
    ACK c89065d

Tree-SHA512: 1f0f49c5c6b42c51001544b213f0a9109e92a64458959e328fb0c7f8d01b47bfa56da47cba6bcb73096418a4873cb643cbc8c6e124923db0f5389985baaac511

Author: apoelstra

src/lib.rs

@@ -384,53 +384,6 @@ impl From<UncheckedHrpstringError> for DecodeError {
     fn from(e: UncheckedHrpstringError) -> Self { Self::Parse(e) }
 }
 
-/// An error while decoding an address from a reader.
-#[cfg(feature = "std")]
-#[derive(Debug)]
-#[non_exhaustive]
-pub enum DecodeFromReaderError {
-    /// Read error.
-    Read(std::io::Error),
-    /// Decode error.
-    Decode(DecodeError),
-}
-
-#[cfg(feature = "std")]
-impl fmt::Display for DecodeFromReaderError {
-    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
-        use DecodeFromReaderError::*;
-
-        match *self {
-            Read(ref e) => write_err!(f, "read failed"; e),
-            Decode(ref e) => write_err!(f, "decoding failed"; e),
-        }
-    }
-}
-
-#[cfg(feature = "std")]
-impl std::error::Error for DecodeFromReaderError {
-    fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
-        use DecodeFromReaderError::*;
-
-        match *self {
-            Read(ref e) => Some(e),
-            Decode(ref e) => Some(e),
-        }
-    }
-}
-
-#[cfg(feature = "std")]
-impl From<std::io::Error> for DecodeFromReaderError {
-    #[inline]
-    fn from(e: std::io::Error) -> Self { Self::Read(e) }
-}
-
-#[cfg(feature = "std")]
-impl From<DecodeError> for DecodeFromReaderError {
-    #[inline]
-    fn from(e: DecodeError) -> Self { Self::Decode(e) }
-}
-
 #[cfg(test)]
 #[cfg(feature = "alloc")]
 mod tests {

src/primitives/segwit.rs

@@ -55,7 +55,7 @@ pub fn validate_witness_program_length(
 /// Field element does not represent a valid witness version.
 #[derive(Debug, Clone, PartialEq, Eq)]
 #[non_exhaustive]
-pub struct InvalidWitnessVersionError(Fe32);
+pub struct InvalidWitnessVersionError(pub Fe32);
 
 impl fmt::Display for InvalidWitnessVersionError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {

src/segwit.rs

@@ -288,53 +288,6 @@ impl From<SegwitHrpstringError> for DecodeError {
     fn from(e: SegwitHrpstringError) -> Self { Self(e) }
 }
 
-/// An error while decoding a segwit address from a reader.
-#[cfg(feature = "std")]
-#[derive(Debug)]
-#[non_exhaustive]
-pub enum DecodeFromReaderError {
-    /// Read error.
-    Read(std::io::Error),
-    /// Decode error.
-    Decode(DecodeError),
-}
-
-#[cfg(feature = "std")]
-impl fmt::Display for DecodeFromReaderError {
-    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
-        use DecodeFromReaderError::*;
-
-        match *self {
-            Read(ref e) => write_err!(f, "read failed"; e),
-            Decode(ref e) => write_err!(f, "decoding failed"; e),
-        }
-    }
-}
-
-#[cfg(feature = "std")]
-impl std::error::Error for DecodeFromReaderError {
-    fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
-        use DecodeFromReaderError::*;
-
-        match *self {
-            Read(ref e) => Some(e),
-            Decode(ref e) => Some(e),
-        }
-    }
-}
-
-#[cfg(feature = "std")]
-impl From<std::io::Error> for DecodeFromReaderError {
-    #[inline]
-    fn from(e: std::io::Error) -> Self { Self::Read(e) }
-}
-
-#[cfg(feature = "std")]
-impl From<DecodeError> for DecodeFromReaderError {
-    #[inline]
-    fn from(e: DecodeError) -> Self { Self::Decode(e) }
-}
-
 /// An error while constructing a [`SegwitHrpstring`] type.
 #[derive(Debug, Clone, PartialEq, Eq)]
 #[non_exhaustive]