Merge #93: Run fuzzer in CI

37d285c Run fuzzer in CI (Tobin C. Harding)
bd4e8e2 Rename travis-fuzz.sh to fuzz.sh (Tobin C. Harding)
18214b2 Do not manually check for ascii range (Tobin C. Harding)

Pull request description:

  As we do in `rust-bitcoin` run the fuzzer for each PR and each push.

  Fix: #43

ACKs for top commit:
  apoelstra:
    ACK 37d285c

Tree-SHA512: d98fcc970f46d34e0b9331643648684ef77787e3e21d25884c093d9f049f8a60b09b6d4771f73230ced57db93fd92810e58f342bcca2ed36dcbb9bab7abd79e3

Author: apoelstra

.github/workflows/fuzz.yml

@@ -0,0 +1,47 @@
+name: Fuzz
+
+on: [push, pull_request]
+
+jobs:
+
+  fuzz:
+    if: ${{ !github.event.act }}
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        fuzz_target: [decode_rnd, encode_decode]
+    steps:
+      - name: Install test dependencies
+        run: sudo apt-get update -y && sudo apt-get install -y binutils-dev libunwind8-dev libcurl4-openssl-dev libelf-dev libdw-dev cmake gcc libiberty-dev
+      - uses: actions/checkout@v2
+      - uses: actions/cache@v2
+        id: cache-fuzz
+        with:
+          path: |
+            ~/.cargo/bin
+            fuzz/target
+            target
+          key: cache-${{ matrix.target }}-${{ hashFiles('**/Cargo.toml','**/Cargo.lock') }}
+      - name: Checkout Toolchain
+        uses: dtolnay/rust-toolchain@stable
+      - name: fuzz
+        run: cd fuzz && ./fuzz.sh "${{ matrix.fuzz_target }}"
+      - run: echo "${{ matrix.fuzz_target }}.rs" >executed_${{ matrix.fuzz_target }}
+      - uses: actions/upload-artifact@v2
+        with:
+          name: executed_${{ matrix.fuzz_target }}
+          path: executed_${{ matrix.fuzz_target }}
+
+  verify-execution:
+    if: ${{ !github.event.act }}
+    needs: fuzz
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/download-artifact@v2
+      - name: Display structure of downloaded files
+        run: ls -R
+      - run: find executed_* -type f -exec cat {} + | sort > executed
+      - run: ls fuzz/fuzz_targets | sort > expected
+      - run: diff expected executed

fuzz/Cargo.toml

@@ -12,7 +12,7 @@ afl_fuzz = ["afl"]
 honggfuzz_fuzz = ["honggfuzz"]
 
 [dependencies]
-honggfuzz = { version = "0.5", optional = true }
+honggfuzz = { version = "0.5", default-features = false, optional = true }
 afl = { version = "0.3", optional = true }
 libc = "0.2"
 bech32 = { path = ".." }

fuzz/travis-fuzz.sh renamed to fuzz/fuzz.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 set -e
-cargo install --force honggfuzz
+cargo install --force honggfuzz --no-default-features
 for TARGET in fuzz_targets/*; do
     FILENAME=$(basename $TARGET)
 	FILE="${FILENAME%.*}"

fuzz/fuzz_targets/encode_decode.rs

@@ -1,6 +1,6 @@
 extern crate bech32;
 
-use std::str::FromStr;
+use std::convert::TryFrom;
 
 fn do_test(data: &[u8]) {
     if data.len() < 1 {
@@ -19,7 +19,7 @@ fn do_test(data: &[u8]) {
 
     let dp = data[hrp_end..]
         .iter()
-        .map(|b| bech32::u5::try_from_u8(b % 32).unwrap())
+        .map(|b| bech32::u5::try_from(b % 32).unwrap())
         .collect::<Vec<_>>();
 
     let variant = if data[0] > 0x0f {

src/lib.rs

@@ -415,9 +415,9 @@ fn check_hrp(hrp: &str) -> Result<Case, Error> {
             return Err(Error::InvalidChar(b as char));
         }
 
-        if (b'a'..=b'z').contains(&b) {
+        if b.is_ascii_lowercase() {
             has_lower = true;
-        } else if (b'A'..=b'Z').contains(&b) {
+        } else if b.is_ascii_uppercase() {
             has_upper = true;
         };