Add new waitforX RPCs

Add waitforblock, waitforblockheight and waitfornewblock methods to v17.
They are hidden until v30 with no changes.

Author: jamillambert

client/src/client_sync/v17/hidden.rs

@@ -0,0 +1,46 @@
+// SPDX-License-Identifier: CC0-1.0
+
+//! Macros for implementing JSON-RPC methods on a client.
+//!
+//! Specifically this is `== Hidden ==` methods that are not listed in the
+//! API docs of Bitcoin Core `v0.17`.
+//!
+//! All macros require `Client` to be in scope.
+//!
+//! See or use the `define_jsonrpc_minreq_client!` macro to define a `Client`.
+
+/// Implements Bitcoin Core JSON-RPC API method `waitforblock`.
+#[macro_export]
+macro_rules! impl_client_v17__wait_for_block {
+    () => {
+        impl Client {
+            pub fn wait_for_block(&self, hash: &bitcoin::BlockHash) -> Result<WaitForBlock> {
+                self.call("waitforblock", &[into_json(hash)?])
+            }
+        }
+    };
+}
+
+/// Implements Bitcoin Core JSON-RPC API method `waitforblockheight`.
+#[macro_export]
+macro_rules! impl_client_v17__wait_for_block_height {
+    () => {
+        impl Client {
+            pub fn wait_for_block_height(&self, height: u64) -> Result<WaitForBlockHeight> {
+                self.call("waitforblockheight", &[into_json(height)?])
+            }
+        }
+    };
+}
+
+/// Implements Bitcoin Core JSON-RPC API method `waitfornewblock`.
+#[macro_export]
+macro_rules! impl_client_v17__wait_for_new_block {
+    () => {
+        impl Client {
+            pub fn wait_for_new_block(&self) -> Result<WaitForNewBlock> {
+                self.call("waitfornewblock", &[])
+            }
+        }
+    };
+}

client/src/client_sync/v17/mod.rs

@@ -7,6 +7,7 @@
 pub mod blockchain;
 pub mod control;
 pub mod generating;
+pub mod hidden;
 pub mod mining;
 pub mod network;
 pub mod raw_transactions;
@@ -64,6 +65,11 @@ crate::impl_client_v17__generate_to_address!();
 crate::impl_client_v17__generate!();
 crate::impl_client_v17__invalidate_block!();
 
+// == Hidden ==
+crate::impl_client_v17__wait_for_block!();
+crate::impl_client_v17__wait_for_block_height!();
+crate::impl_client_v17__wait_for_new_block!();
+
 // == Mining ==
 crate::impl_client_v17__get_block_template!();
 crate::impl_client_v17__get_mining_info!();

client/src/client_sync/v18/mod.rs

@@ -70,6 +70,11 @@ crate::impl_client_v17__generate_to_address!();
 crate::impl_client_v17__generate!();
 crate::impl_client_v17__invalidate_block!();
 
+// == Hidden ==
+crate::impl_client_v17__wait_for_block!();
+crate::impl_client_v17__wait_for_block_height!();
+crate::impl_client_v17__wait_for_new_block!();
+
 // == Mining ==
 crate::impl_client_v17__get_block_template!();
 crate::impl_client_v17__get_mining_info!();

client/src/client_sync/v19/mod.rs

@@ -65,6 +65,11 @@ crate::impl_client_v17__uptime!();
 crate::impl_client_v17__generate_to_address!();
 crate::impl_client_v17__invalidate_block!();
 
+// == Hidden ==
+crate::impl_client_v17__wait_for_block!();
+crate::impl_client_v17__wait_for_block_height!();
+crate::impl_client_v17__wait_for_new_block!();
+
 // == Mining ==
 crate::impl_client_v17__get_block_template!();
 crate::impl_client_v17__get_mining_info!();

client/src/client_sync/v20/mod.rs

@@ -65,6 +65,11 @@ crate::impl_client_v17__generate_to_address!();
 crate::impl_client_v20__generate_to_descriptor!();
 crate::impl_client_v17__invalidate_block!();
 
+// == Hidden ==
+crate::impl_client_v17__wait_for_block!();
+crate::impl_client_v17__wait_for_block_height!();
+crate::impl_client_v17__wait_for_new_block!();
+
 // == Mining ==
 crate::impl_client_v17__get_block_template!();
 crate::impl_client_v17__get_mining_info!();

client/src/client_sync/v21/mod.rs

@@ -72,6 +72,9 @@ crate::impl_client_v17__invalidate_block!();
 
 // == Hidden ==
 crate::impl_client_v21__add_peer_address!();
+crate::impl_client_v17__wait_for_block!();
+crate::impl_client_v17__wait_for_block_height!();
+crate::impl_client_v17__wait_for_new_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v22/mod.rs

@@ -70,6 +70,9 @@ crate::impl_client_v17__invalidate_block!();
 
 // == Hidden ==
 crate::impl_client_v21__add_peer_address!();
+crate::impl_client_v17__wait_for_block!();
+crate::impl_client_v17__wait_for_block_height!();
+crate::impl_client_v17__wait_for_new_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v23/mod.rs

@@ -73,6 +73,9 @@ crate::impl_client_v17__invalidate_block!();
 
 // == Hidden ==
 crate::impl_client_v21__add_peer_address!();
+crate::impl_client_v17__wait_for_block!();
+crate::impl_client_v17__wait_for_block_height!();
+crate::impl_client_v17__wait_for_new_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v24/mod.rs

@@ -74,6 +74,9 @@ crate::impl_client_v17__invalidate_block!();
 
 // == Hidden ==
 crate::impl_client_v21__add_peer_address!();
+crate::impl_client_v17__wait_for_block!();
+crate::impl_client_v17__wait_for_block_height!();
+crate::impl_client_v17__wait_for_new_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v25/mod.rs

@@ -75,6 +75,9 @@ crate::impl_client_v17__invalidate_block!();
 
 // == Hidden ==
 crate::impl_client_v21__add_peer_address!();
+crate::impl_client_v17__wait_for_block!();
+crate::impl_client_v17__wait_for_block_height!();
+crate::impl_client_v17__wait_for_new_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();