Merge #288: Implement walletpassphrasechange method and test

75f8e9e Implement walletpassphrasechange method and test (GideonBature)

Pull request description:

  The JSON-RPC method `walletpassphrasechange` does not return anything. We want to test this to catch any changes in behavior in future Core versions.

  This PR adds a client function that errors if the return value is anything other than `null`, along with an integration test that calls this function.

  Ref: [#116](#116)

ACKs for top commit:
  jamillambert:
    ACK 75f8e9e
  tcharding:
    ACK 75f8e9e

Tree-SHA512: 1152bfaf0ae2db7c8c76446ed0942c14ac8956d58a1cc5538311560c97f2bc092a3a9f8c7ce023aa8430df87ced7e4e528dd530a031cddc03ffdf2ee06ac4ef0

Author: tcharding

client/src/client_sync/v17/mod.rs

@@ -156,6 +156,7 @@ crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_passphrase!();
+crate::impl_client_v17__wallet_passphrase_change!();
 crate::impl_client_v17__wallet_process_psbt!();
 
 /// Argument to the `Client::get_new_address_with_type` function.

client/src/client_sync/v17/wallet.rs

@@ -714,6 +714,28 @@ macro_rules! impl_client_v17__wallet_lock {
     };
 }
 
+/// Implements Bitcoin Core JSON-RPC API method `walletpassphrasechange`
+#[macro_export]
+macro_rules! impl_client_v17__wallet_passphrase_change {
+    () => {
+        impl Client {
+            pub fn wallet_passphrase_change(
+                &self,
+                old_passphrase: &str,
+                new_passphrase: &str,
+            ) -> Result<()> {
+                match self
+                    .call("walletpassphrasechange", &[old_passphrase.into(), new_passphrase.into()])
+                {
+                    Ok(serde_json::Value::Null) => Ok(()),
+                    Ok(res) => Err(Error::Returned(res.to_string())),
+                    Err(err) => Err(err.into()),
+                }
+            }
+        }
+    };
+}
+
 /// Implements Bitcoin Core JSON-RPC API method `walletprocesspsbt`.
 #[macro_export]
 macro_rules! impl_client_v17__wallet_process_psbt {

client/src/client_sync/v18/mod.rs

@@ -173,4 +173,5 @@ crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_passphrase!();
+crate::impl_client_v17__wallet_passphrase_change!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v19/mod.rs

@@ -170,4 +170,5 @@ crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_passphrase!();
+crate::impl_client_v17__wallet_passphrase_change!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v20/mod.rs

@@ -170,4 +170,5 @@ crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_passphrase!();
+crate::impl_client_v17__wallet_passphrase_change!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v21/mod.rs

@@ -180,6 +180,7 @@ crate::impl_client_v21__upgrade_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_passphrase!();
+crate::impl_client_v17__wallet_passphrase_change!();
 crate::impl_client_v17__wallet_process_psbt!();
 
 /// Request object for the `importdescriptors` method.

client/src/client_sync/v22/mod.rs

@@ -178,4 +178,5 @@ crate::impl_client_v21__upgrade_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_passphrase!();
+crate::impl_client_v17__wallet_passphrase_change!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v23/mod.rs

@@ -180,6 +180,7 @@ crate::impl_client_v21__upgrade_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_passphrase!();
+crate::impl_client_v17__wallet_passphrase_change!();
 crate::impl_client_v17__wallet_process_psbt!();
 
 /// Argument to the `Client::get_new_address_with_type` function.

client/src/client_sync/v24/mod.rs

@@ -177,4 +177,5 @@ crate::impl_client_v21__upgrade_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_passphrase!();
+crate::impl_client_v17__wallet_passphrase_change!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v25/mod.rs

@@ -179,4 +179,5 @@ crate::impl_client_v21__upgrade_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_passphrase!();
+crate::impl_client_v17__wallet_passphrase_change!();
 crate::impl_client_v17__wallet_process_psbt!();