Merge #286: Implement walletlock method and test

22acb26 Implement walletlock method and test (GideonBature)

Pull request description:

  The JSON-RPC method `walletlock` does not return anything. We want to test this to catch any changes in behavior in future Core versions.

  This PR adds a client function that errors if the return value is anything other than `null`, along with an integration test that calls this function.

  Ref: [#116](#116)

ACKs for top commit:
  jamillambert:
    ACK 22acb26
  tcharding:
    ACK 22acb26

Tree-SHA512: 6c339d362b49b03392bfb5a122cabf9220579cf88a7278f003784859123915d5e0e741364cc2c769a48350ac32e59a297c2c7c1af999ffa1c7bc2b586c199453

Author: tcharding

client/src/client_sync/v17/mod.rs

@@ -154,6 +154,7 @@ crate::impl_client_v17__sign_message!();
 crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
+crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_process_psbt!();
 
 /// Argument to the `Client::get_new_address_with_type` function.

client/src/client_sync/v17/wallet.rs

@@ -682,6 +682,22 @@ macro_rules! impl_client_v17__wallet_create_funded_psbt {
     };
 }
 
+/// Implements Bitcoin Core JSON-RPC API method `walletlock`.
+#[macro_export]
+macro_rules! impl_client_v17__wallet_lock {
+    () => {
+        impl Client {
+            pub fn wallet_lock(&self) -> Result<()> {
+                match self.call("walletlock", &[]) {
+                    Ok(serde_json::Value::Null) => Ok(()),
+                    Ok(res) => Err(Error::Returned(res.to_string())),
+                    Err(err) => Err(err.into()),
+                }
+            }
+        }
+    };
+}
+
 /// Implements Bitcoin Core JSON-RPC API method `walletprocesspsbt`.
 #[macro_export]
 macro_rules! impl_client_v17__wallet_process_psbt {

client/src/client_sync/v18/mod.rs

@@ -171,4 +171,5 @@ crate::impl_client_v17__sign_message!();
 crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
+crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v19/mod.rs

@@ -168,4 +168,5 @@ crate::impl_client_v17__sign_message!();
 crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
+crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v20/mod.rs

@@ -168,4 +168,5 @@ crate::impl_client_v17__sign_message!();
 crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
+crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v21/mod.rs

@@ -168,4 +168,5 @@ crate::impl_client_v17__sign_message!();
 crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v21__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
+crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v22/mod.rs

@@ -168,4 +168,5 @@ crate::impl_client_v17__sign_message!();
 crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v21__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
+crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v23/mod.rs

@@ -170,6 +170,7 @@ crate::impl_client_v17__sign_message!();
 crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v21__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
+crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_process_psbt!();
 
 /// Argument to the `Client::get_new_address_with_type` function.

client/src/client_sync/v24/mod.rs

@@ -167,4 +167,5 @@ crate::impl_client_v17__sign_message!();
 crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v21__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
+crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v25/mod.rs

@@ -167,4 +167,5 @@ crate::impl_client_v17__sign_message!();
 crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v21__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
+crate::impl_client_v17__wallet_lock!();
 crate::impl_client_v17__wallet_process_psbt!();