Add migratewallet method and test

Add the struct, client macro, reexports and test.

No model is required, change the types table to `version`, update verify
and remove TODO.

Author: jamillambert

client/src/client_sync/v24/mod.rs

@@ -171,6 +171,7 @@ crate::impl_client_v18__list_wallet_dir!();
 crate::impl_client_v17__list_wallets!();
 crate::impl_client_v22__load_wallet!();
 crate::impl_client_v17__lock_unspent!();
+crate::impl_client_v24__migrate_wallet!();
 crate::impl_client_v23__new_keypool!();
 crate::impl_client_v21__psbt_bump_fee!();
 crate::impl_client_v17__remove_pruned_funds!();

client/src/client_sync/v24/wallet.rs

@@ -9,6 +9,18 @@
 //!
 //! See or use the `define_jsonrpc_minreq_client!` macro to define a `Client`.
 
+/// Implements Bitcoin Core JSON-RPC API method `migratewallet`.
+#[macro_export]
+macro_rules! impl_client_v24__migrate_wallet {
+    () => {
+        impl Client {
+            pub fn migrate_wallet(&self, wallet_name: &str) -> Result<MigrateWallet> {
+                self.call("migratewallet", &[wallet_name.into()])
+            }
+        }
+    };
+}
+
 /// Implements Bitcoin Core JSON-RPC API method `sendall`.
 #[macro_export]
 macro_rules! impl_client_v24__send_all {

client/src/client_sync/v25/mod.rs

@@ -170,6 +170,7 @@ crate::impl_client_v18__list_wallet_dir!();
 crate::impl_client_v17__list_wallets!();
 crate::impl_client_v22__load_wallet!();
 crate::impl_client_v17__lock_unspent!();
+crate::impl_client_v24__migrate_wallet!();
 crate::impl_client_v23__new_keypool!();
 crate::impl_client_v21__psbt_bump_fee!();
 crate::impl_client_v17__remove_pruned_funds!();

client/src/client_sync/v26/mod.rs

@@ -174,6 +174,7 @@ crate::impl_client_v18__list_wallet_dir!();
 crate::impl_client_v17__list_wallets!();
 crate::impl_client_v22__load_wallet!();
 crate::impl_client_v17__lock_unspent!();
+crate::impl_client_v24__migrate_wallet!();
 crate::impl_client_v23__new_keypool!();
 crate::impl_client_v21__psbt_bump_fee!();
 crate::impl_client_v17__remove_pruned_funds!();

client/src/client_sync/v27/mod.rs

@@ -170,6 +170,7 @@ crate::impl_client_v18__list_wallet_dir!();
 crate::impl_client_v17__list_wallets!();
 crate::impl_client_v22__load_wallet!();
 crate::impl_client_v17__lock_unspent!();
+crate::impl_client_v24__migrate_wallet!();
 crate::impl_client_v23__new_keypool!();
 crate::impl_client_v21__psbt_bump_fee!();
 crate::impl_client_v17__remove_pruned_funds!();

client/src/client_sync/v28/mod.rs

@@ -172,6 +172,7 @@ crate::impl_client_v18__list_wallet_dir!();
 crate::impl_client_v17__list_wallets!();
 crate::impl_client_v22__load_wallet!();
 crate::impl_client_v17__lock_unspent!();
+crate::impl_client_v24__migrate_wallet!();
 crate::impl_client_v23__new_keypool!();
 crate::impl_client_v21__psbt_bump_fee!();
 crate::impl_client_v17__remove_pruned_funds!();

client/src/client_sync/v29/mod.rs

@@ -172,6 +172,7 @@ crate::impl_client_v18__list_wallet_dir!();
 crate::impl_client_v17__list_wallets!();
 crate::impl_client_v22__load_wallet!();
 crate::impl_client_v17__lock_unspent!();
+crate::impl_client_v24__migrate_wallet!();
 crate::impl_client_v23__new_keypool!();
 crate::impl_client_v21__psbt_bump_fee!();
 crate::impl_client_v17__remove_pruned_funds!();

integration_test/tests/wallet.rs

@@ -573,6 +573,18 @@ fn wallet__lock_unspent() {
     assert!(json.0);
 }
 
+#[cfg(not(feature = "v23_and_below"))]
+#[test]
+fn wallet__migrate_wallet() {
+    let node = Node::with_wallet(Wallet::None, &["-deprecatedrpc=create_bdb"]);
+    let wallet_name = "legacy_wallet";
+    node.client.create_legacy_wallet(wallet_name).expect("createlegacywallet");
+
+    let json: MigrateWallet = node.client.migrate_wallet(wallet_name).expect("migratewallet");
+
+    assert_eq!(json.wallet_name, wallet_name);
+}
+
 #[cfg(not(feature = "v22_and_below"))]
 #[test]
 fn wallet__new_keypool() {

types/src/v24/mod.rs

@@ -193,7 +193,7 @@
 //! | listdescriptors                    | version         |                                        |
 //! | listlabels                         | version + model | UNTESTED                               |
 //! | listlockunspent                    | version + model | UNTESTED                               |
-//! | migratewallet                      | version + model | TODO                                   |
+//! | migratewallet                      | version         |                                        |
 //! | newkeypool                         | returns nothing |                                        |
 //! | psbtbumpfee                        | version + model |                                        |
 //! | listreceivedbyaddress              | version + model | UNTESTED                               |
@@ -258,7 +258,7 @@ pub use self::{
     },
     wallet::{
         GetTransaction, GetTransactionDetail, GetTransactionError, ListUnspent, ListUnspentItem,
-        SendAll, SendAllError,
+        MigrateWallet, SendAll, SendAllError,
     },
 };
 #[doc(inline)]

types/src/v24/wallet/mod.rs

@@ -167,6 +167,36 @@ pub struct ListUnspentItem {
     pub parent_descriptors: Option<Vec<String>>,
 }
 
+/// Result of JSON-RPC method `migratewallet`.
+///
+/// > migratewallet ( "wallet_name" "passphrase" )
+/// >
+/// > EXPERIMENTAL warning: This call may not work as expected and may be changed in future releases
+/// >
+/// > Migrate the wallet to a descriptor wallet.
+/// > A new wallet backup will need to be made.
+/// >
+/// > The migration process will create a backup of the wallet before migrating. This backup
+/// > file will be named {wallet name}-{timestamp}.legacy.bak and can be found in the directory
+/// > for this wallet. In the event of an incorrect migration, the backup can be restored using restorewallet.
+/// > Encrypted wallets must have the passphrase provided as an argument to this call.
+/// >
+/// > Arguments:
+/// > 1. wallet_name    (string, optional, default=the wallet name from the RPC endpoint) The name of the wallet to migrate. If provided both here and in the RPC endpoint, the two must be identical.
+/// > 2. passphrase     (string) The wallet passphrase
+#[derive(Clone, Debug, PartialEq, Deserialize, Serialize)]
+#[serde(deny_unknown_fields)]
+pub struct MigrateWallet {
+    /// The name of the primary migrated wallet
+    pub wallet_name: String,
+    /// The name of the migrated wallet containing the watchonly scripts
+    pub watchonly_name: Option<String>,
+    /// The name of the migrated wallet containing solvable but not watched scripts
+    pub solvables_name: Option<String>,
+    /// The location of the backup of the original wallet
+    pub backup_path: String,
+}
+
 /// Result of JSON-RPC method `sendall`.
 ///
 /// > sendall ["address",{"address":amount,...},...] ( conf_target "estimate_mode" fee_rate options )