Merge #287: Implement walletpassphrase method and test

86b06c5 Implement walletpassphrase method and test (GideonBature)

Pull request description:

  The JSON-RPC method `walletpassphrase` does not return anything. We want to test this to catch any changes in behavior in future Core versions.

  This PR adds a client function that errors if the return value is anything other than `null`, along with an integration test that calls this function.

  Ref: [#116](#116)

ACKs for top commit:
  jamillambert:
    ACK 86b06c5
  tcharding:
    ACK 86b06c5

Tree-SHA512: 54a44b8084ec3a5395e1cbf175a56aaa143b9ff97396b491159ee703497ac956ff8b8726d400cecf472d0ff87f0cc31365529856e6b9e24ad66e3a3c514bd524

Author: tcharding

client/src/client_sync/v17/mod.rs

@@ -155,6 +155,7 @@ crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
+crate::impl_client_v17__wallet_passphrase!();
 crate::impl_client_v17__wallet_process_psbt!();
 
 /// Argument to the `Client::get_new_address_with_type` function.

client/src/client_sync/v17/wallet.rs

@@ -666,6 +666,22 @@ macro_rules! impl_client_v17__unload_wallet {
     };
 }
 
+/// Implements Bitcoin Core JSON-RPC API method `walletpassphrase`
+#[macro_export]
+macro_rules! impl_client_v17__wallet_passphrase {
+    () => {
+        impl Client {
+            pub fn wallet_passphrase(&self, passphrase: &str, timeout: u64) -> Result<()> {
+                match self.call("walletpassphrase", &[passphrase.into(), timeout.into()]) {
+                    Ok(serde_json::Value::Null) => Ok(()),
+                    Ok(res) => Err(Error::Returned(res.to_string())),
+                    Err(err) => Err(err.into()),
+                }
+            }
+        }
+    };
+}
+
 /// Implements Bitcoin Core JSON-RPC API method `walletcreatefundedpsbt`.
 #[macro_export]
 macro_rules! impl_client_v17__wallet_create_funded_psbt {

client/src/client_sync/v18/mod.rs

@@ -172,4 +172,5 @@ crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
+crate::impl_client_v17__wallet_passphrase!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v19/mod.rs

@@ -169,4 +169,5 @@ crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
+crate::impl_client_v17__wallet_passphrase!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v20/mod.rs

@@ -169,4 +169,5 @@ crate::impl_client_v17__sign_raw_transaction_with_wallet!();
 crate::impl_client_v17__unload_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
+crate::impl_client_v17__wallet_passphrase!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v21/mod.rs

@@ -179,6 +179,7 @@ crate::impl_client_v21__unload_wallet!();
 crate::impl_client_v21__upgrade_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
+crate::impl_client_v17__wallet_passphrase!();
 crate::impl_client_v17__wallet_process_psbt!();
 
 /// Request object for the `importdescriptors` method.

client/src/client_sync/v22/mod.rs

@@ -177,4 +177,5 @@ crate::impl_client_v21__unload_wallet!();
 crate::impl_client_v21__upgrade_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
+crate::impl_client_v17__wallet_passphrase!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v23/mod.rs

@@ -179,6 +179,7 @@ crate::impl_client_v21__unload_wallet!();
 crate::impl_client_v21__upgrade_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
+crate::impl_client_v17__wallet_passphrase!();
 crate::impl_client_v17__wallet_process_psbt!();
 
 /// Argument to the `Client::get_new_address_with_type` function.

client/src/client_sync/v24/mod.rs

@@ -176,4 +176,5 @@ crate::impl_client_v21__unload_wallet!();
 crate::impl_client_v21__upgrade_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
+crate::impl_client_v17__wallet_passphrase!();
 crate::impl_client_v17__wallet_process_psbt!();

client/src/client_sync/v25/mod.rs

@@ -178,4 +178,5 @@ crate::impl_client_v21__unload_wallet!();
 crate::impl_client_v21__upgrade_wallet!();
 crate::impl_client_v17__wallet_create_funded_psbt!();
 crate::impl_client_v17__wallet_lock!();
+crate::impl_client_v17__wallet_passphrase!();
 crate::impl_client_v17__wallet_process_psbt!();