Changelog #189

Author: lnicola

generated_assists.adoc

@@ -1558,7 +1558,7 @@ fn bar(arg: &str, baz: Baz) ${0:-> _} {
 
 [discrete]
 === `generate_getter`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_getter.rs#L13[generate_getter.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_getter_or_setter.rs#L73[generate_getter_or_setter.rs]
 
 Generate a getter method.
 
@@ -1585,7 +1585,7 @@ impl Person {
 
 [discrete]
 === `generate_getter_mut`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_getter.rs#L53[generate_getter.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_getter_or_setter.rs#L113[generate_getter_or_setter.rs]
 
 Generate a mut getter method.
 
@@ -1698,7 +1698,7 @@ impl<T: Clone> Ctx<T> {
 
 [discrete]
 === `generate_setter`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_setter.rs#L9[generate_setter.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_getter_or_setter.rs#L13[generate_getter_or_setter.rs]
 
 Generate a setter method.
 
@@ -1716,13 +1716,73 @@ struct Person {
 }
 
 impl Person {
-    fn set_name(&mut self, name: String) {
+    fn ┃set_name(&mut self, name: String) {
         self.name = name;
     }
 }
 ```
 
 
+[discrete]
+=== `generate_trait_from_impl`
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_trait_from_impl.rs#L13[generate_trait_from_impl.rs]
+
+Generate trait for an already defined inherent impl and convert impl to a trait impl.
+
+.Before
+```rust
+struct Foo<const N: usize>([i32; N]);
+
+macro_rules! const_maker {
+    ($t:ty, $v:tt) => {
+        const CONST: $t = $v;
+    };
+}
+
+impl<const N: usize> Fo┃o<N> {
+    // Used as an associated constant.
+    const CONST_ASSOC: usize = N * 4;
+
+    fn create() -> Option<()> {
+        Some(())
+    }
+
+    const_maker! {i32, 7}
+}
+```
+
+.After
+```rust
+struct Foo<const N: usize>([i32; N]);
+
+macro_rules! const_maker {
+    ($t:ty, $v:tt) => {
+        const CONST: $t = $v;
+    };
+}
+
+trait ${0:TraitName}<const N: usize> {
+    // Used as an associated constant.
+    const CONST_ASSOC: usize = N * 4;
+
+    fn create() -> Option<()>;
+
+    const_maker! {i32, 7}
+}
+
+impl<const N: usize> ${0:TraitName}<N> for Foo<N> {
+    // Used as an associated constant.
+    const CONST_ASSOC: usize = N * 4;
+
+    fn create() -> Option<()> {
+        Some(())
+    }
+
+    const_maker! {i32, 7}
+}
+```
+
+
 [discrete]
 === `generate_trait_impl`
 **Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_impl.rs#L56[generate_impl.rs]

generated_diagnostic.adoc

@@ -44,7 +44,7 @@ This diagnostic is shown for macro expansion errors.
 
 
 === macro-error
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/macro_error.rs#L12[macro_error.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/macro_error.rs#L17[macro_error.rs]
 
 This diagnostic is shown for macro expansion errors.
 
@@ -217,6 +217,6 @@ enable support for procedural macros (see `rust-analyzer.procMacro.attributes.en
 
 
 === unused-mut
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/mutability_errors.rs#L43[mutability_errors.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/mutability_errors.rs#L45[mutability_errors.rs]
 
 This diagnostic is triggered when a mutable variable isn't actually mutated.

generated_features.adoc

@@ -994,6 +994,18 @@ Only workspace crates are included, no crates.io dependencies or sysroot crates.
 image::https://user-images.githubusercontent.com/48062697/113065588-068bdb80-91b1-11eb-9a78-0b4ef1e972fb.gif[]
 
 
+=== View Memory Layout
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/view_memory_layout.rs#L83[view_memory_layout.rs]
+
+Displays the recursive memory layout of a datatype.
+
+|===
+| Editor  | Action Name
+
+| VS Code | **rust-analyzer: View Memory Layout**
+|===
+
+
 === View Mir
 **Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/view_mir.rs#L6[view_mir.rs]
 

manual.adoc

@@ -64,22 +64,8 @@ You can install the latest release of the plugin from
 https://marketplace.visualstudio.com/items?itemName=rust-lang.rust-analyzer[the marketplace].
 
 Note that the plugin may cause conflicts with the
-https://marketplace.visualstudio.com/items?itemName=rust-lang.rust[official Rust plugin].
-It is recommended to disable the Rust plugin when using the rust-analyzer extension.
-
-By default, the plugin will prompt you to download the matching version of the server as well:
-
-image::https://user-images.githubusercontent.com/9021944/75067008-17502500-54ba-11ea-835a-f92aac50e866.png[]
-
-[NOTE]
-====
-To disable this notification put the following to `settings.json`
-
-[source,json]
-----
-{ "rust-analyzer.updates.askBeforeDownload": false }
-----
-====
+https://marketplace.visualstudio.com/items?itemName=rust-lang.rust[previous official Rust plugin].
+The latter is no longer maintained and should be uninstalled.
 
 The server binary is stored in the extension install directory, which starts with `rust-lang.rust-analyzer-` and is located under:
 
@@ -141,6 +127,9 @@ If you're not using Code, you can compile and install only the LSP server:
 $ cargo xtask install --server
 ----
 
+Make sure that `.cargo/bin` is in `$PATH` and precedes paths where `rust-analyzer` may also be installed.
+Specifically, `rustup` includes a proxy called `rust-analyzer`, which can cause problems if you're planning to use a source build or even a downloaded binary.
+
 === rust-analyzer Language Server Binary
 
 Other editors generally require the `rust-analyzer` binary to be in `$PATH`.

thisweek/_posts/2023-07-10-changelog-189.adoc

@@ -0,0 +1,50 @@
+= Changelog #189
+:sectanchors:
+:experimental:
+:page-layout: post
+
+Commit: commit:ff15634831f4a3cdb8abf5690a9848a6fdf48432[] +
+Release: release:2023-07-10[] (`v0.3.1583`)
+
+== New Features
+
+* pr:15081[] (first contribution) add a memory layout viewer:
++
+image::https://user-images.githubusercontent.com/308347/252252339-e394e713-ebb9-4567-9acc-60f4a2a19407.png["Screenshot showing a memory layout view for a struct with `i32`, `u8`, `Vec<bool>` and `usize` fields."]
+* pr:15152[] add `Generate trait from impl` assist:
++
+image::https://user-images.githubusercontent.com/20956650/249216814-05d4dda5-604a-4108-8b82-9b60bd45894a.gif["Screen recording showing the assist generating a trait from an `impl` block"]
+* pr:14990[] map our diagnostics to the `rustc` and `clippy` ones.
+* pr:15186[] don't add panics to error jump list by default.
+
+== Fixes
+
+* pr:15118[] (first contribution) follow raw pointers in autoderef chain when resolving methods with custom receiver.
+* pr:15235[] (first contribution) don't insert semicolon when extracting `match` arm.
+* pr:15226[] make `Expand glob import` work on enum imports.
+* pr:15211[] support GATs in bounds for associated types.
+* pr:15223[] don't show `unresolved-field` diagnostic for missing names.
+* pr:15216[] don't mark braces around `self` imports as unnecessary.
+* pr:15212[] recover from missing associated items and generic const defaults.
+* pr:15245[] fix missing terminator in pattern matching of consts.
+* pr:15222[] fix `size_of_val` and support `min_align_of_val` intrinsic.
+* pr:15244[] support `read_via_copy` intrinsic.
+* pr:15228[] implement recursion in MIR interpreter without recursion.
+* pr:15230[] use `Debug` impl for const eval result rendering.
+* pr:15227[] indent after pressing enter on a blank line.
+
+== Internal Improvements
+
+* pr:15202[] don't diagnose built-in derives.
+* pr:15204[] add analysis-stats flag to trigger some IDE features.
+* pr:15149[] speed up line index calculation via SSE2.
+* pr:15219[] unify Generate getter and setter assists.
+* pr:15205[] split out project loading capabilities from the `rust-analyzer` crate.
+* pr:15203[] shuffle some `proc_macro_expand` query things around.
+* pr:15209[] use stronger typing for `AstId` and `AstIdMap`.
+* pr:15181[] clean up `ImportMap`.
+* pr:15210[] remove `CfgExpander`.
+* pr:15206[] format `let`-`else`.
+* pr:15224[] replace `x` with `it`.
+* pr:15160[] enable `noUncheckedIndexedAccess` and `noPropertyAccessFromIndexSignature` TypeScript options.
+* pr:15234[] remind user to check `PATH` after installation.