avm2: Fix errors thrown in constructprop and construct operations
#22352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
added
A-avm2
Lord-McSweeney
force-pushed
the
avm2-construct-errors
branch
from
2a8a45e to
26250c6
Compare
`ConstructProp` is not equivalent to `GetProperty` followed by `Construct`
…eration `constructprop` has different semantics than just `getproperty` followed by `construct`, so we can't just run `Value::get_property` and `Value::construct`. This adds new `make_error_1007` and `make_error_1115` functions. This progresses the avmplus test `regress/bug_638233`
Test for constructing an associated method and dynamic properties on a primitive class's prototype
Lord-McSweeney
force-pushed
the
avm2-construct-errors
branch
from
cabda42 to
ceae97a
Compare
Lord-McSweeney
removed
the
waiting-on-review
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Dec 3, 2025
------------------------------------------------------------------------------------------ duckstation.mk b42f26fbacf27906b2fab9b2b45dd5a27bbcbc46 # Version: Commits on Dec 03, 2025 ------------------------------------------------------------------------------------------ SDLInputSource: Log the joystick GUID as well (#3653), ----------------------------------------------------------------------------------- eden.mk fe8017734b48eaf092ebe4e4930c4d9a48a586c6 # Version: Commits on Dec 03, 2025 ----------------------------------------------------------------------------------- [cmake, externals] android x86_64 support (#3086) ------------------------------------------------------------------------------------ rpcs3.mk cbba687ffab9b0831116a4926bbf343546669880 # Version: Commits on Dec 02, 2025 ------------------------------------------------------------------------------------ Qt: Relax game_list deselection checks, ----------------------------------------------------- ryujinx.mk 1.3.228 # Version: Commits on Dec 03, 2025 ----------------------------------------------------- Canary-1.3.228 ------------------------------------------------------------------------------------------- xenia-native.mk 78e753ef524bf5495365420127817858511f3eae # Version: Commits on Nov 30, 2025 ------------------------------------------------------------------------------------------- [GPU] Added config option to enable/disable invalid memory uploads, --------------------------------------------------------------- ruffle.mk nightly-2025-12-03 # Version: Commits on Dec 03, 2025 --------------------------------------------------------------- ## What's Changed * build(deps): bump the cargo-minor group with 4 updates by @dependabot[bot] in ruffle-rs/ruffle#22386 * build(deps): bump AurorNZ/paths-filter from 4 to 5 by @dependabot[bot] in ruffle-rs/ruffle#22389 * avm2: Fix errors thrown in `constructprop` and `construct` operations by @Lord-McSweeney in ruffle-rs/ruffle#22352 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-12-02...nightly-2025-12-03, ------------------------------------------------------------------------------------------- sdl12-compat.mk a26094d2bc437cb45055f6a474f95779c7181bca # Version: Commits on Dec 02, 2025 ------------------------------------------------------------------------------------------- Updated to version 1.2.73 for development, ------------------------------------------------------------------------------------------ devilutionx.mk bc0d60bff79dd96743e8a13028494968bfaff2a7 # Version: Commits on Dec 03, 2025 ------------------------------------------------------------------------------------------ Add Player hasNoMana helper, --------------------------------------------------------------------------------------- etlegacy.mk 1de309130313034b6e9fc1bb0e304db554e0a07f # Version: Commits on Dec 03, 2025 --------------------------------------------------------------------------------------- github-actions: align to fix issue, ---------------------------------------------------------------------------------------- openjkdf2.mk 522fce4960ddbdd305418a32237b31e23afe9849 # Version: Commits on Dec 03, 2025 ---------------------------------------------------------------------------------------- v0.9.7, ---------------------------------------------------------------------------------------- openmohaa.mk 701964b8c2dacb274c2b5589a02bb65a887bb461 # Version: Commits on Dec 02, 2025 ---------------------------------------------------------------------------------------- refactor(cgame): wrap animation time using modulo, ---------------------------------------------------------------------------------------- supertux2.mk 4438a10f59a69599e85c2d36709fd57db5a7d749 # Version: Commits on Dec 03, 2025 ---------------------------------------------------------------------------------------- Improve Credits' Organization (Rebase) (#3371) * Update credits.stxt * Fix formatting [ci skip] * Adjust my name and Frosts --------- Co-authored-by: xornamed <69918580+bruhmoent@users.noreply.github.com> Co-authored-by: swagtoy <me@ow.nekobit.net>, ---------------------------------------------------------------------------------------- retroarch.mk e37f52d36a607cf39931fd5413b14a9c597cfd21 # Version: Commits on Dec 03, 2025 ---------------------------------------------------------------------------------------- linux: sensors: illminance: Fix failure to open file resulting in success code being sent. (#18483), ---------------------------------------------------------------------------------------- doomretro.mk 2726e79d699a1e7a5a206e23608258006988f6af # Version: Commits on Dec 03, 2025 ---------------------------------------------------------------------------------------- Remove any space preceding ellipsis when truncating, ----------------------------------------------------------------------------------------------------- libretro-mame2003-plus.mk e58d3285f4323a19a0f5aea01f4cdf7a934e1155 # Version: Commits on Dec 02, 2025 ----------------------------------------------------------------------------------------------------- ffs it's eye not eve :), ----------------------------------------------------------------------------------------------- libretro-scummvm.mk 8270de6cb8504906d7ee7d7ed0d57d9ae9c22ea5 # Version: Commits on Dec 03, 2025 ----------------------------------------------------------------------------------------------- NEWS: Synchronize with master, --------------------------------------------------------------------------------------------- libretro-vba-m.mk c6984254a896a68a3a204dae915db41030759339 # Version: Commits on Dec 03, 2025 --------------------------------------------------------------------------------------------- Fix binding game keys in input config Fix binding game keys in input config, broken by recent menu handling code. Fixed with Claude. Signed-off-by: Rafael Kitover <rkitover@gmail.com>, -------------------------------------------------------------------------------------------- slang-shaders.mk cf5c768ffda2520d4938df68d33fd63fff276c0c # Version: Commits on Dec 03, 2025 -------------------------------------------------------------------------------------------- move cyanosin's GTU deinterlacing shaders to the deinterlacing directory (#817),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dedicated
Value::construct_propfunction. The AVM2constructpropop isn't equivalent to agetpropertyfollowed by aconstruct, so we have to do it this way to match avmplus.This progresses
from_avmplus/regress/bug_638233and closes #21417