Remove RELASE_ARTIFACTS for better maintainability

Author: kateinoigakukun

tasks/ci.rake

@@ -13,16 +13,6 @@ def latest_build_sources
     .to_h
 end
 
-NPM_RELEASE_ARTIFACTS = %w[
-  npm-ruby-head-wasm-emscripten
-  npm-ruby-head-wasm-wasi
-  npm-ruby-3_2-wasm-wasi
-]
-RELASE_ARTIFACTS =
-  BUILD_TASKS.map do |build|
-    File.basename(build.crossruby.artifact, ".tar.gz")
-  end + NPM_RELEASE_ARTIFACTS
-
 def release_note
   output = <<EOS
 | channel | source |
@@ -52,56 +42,60 @@ def sh_or_warn(*cmd)
   end
 end
 
+def rake_task_matrix
+  require "pathname"
+  ruby_cache_keys = {}
+  BUILD_TASKS.each { |build| ruby_cache_keys[build.name] = build.hexdigest }
+  build_entries =
+    BUILD_TASKS.map do |build|
+      {
+        task: "build:#{build.name}",
+        artifact:
+          Pathname
+            .new(build.crossruby.artifact)
+            .relative_path_from(LIB_ROOT)
+            .to_s,
+        artifact_name: File.basename(build.crossruby.artifact, ".tar.gz"),
+        builder: build.target,
+        rubies_cache_key: ruby_cache_keys[build.name]
+      }
+    end
+  npm_entries =
+    NPM_PACKAGES.map do |pkg|
+      entry = {
+        task: "npm:#{pkg[:name]}",
+        prerelease: "npm:configure_prerelease",
+        artifact: "packages/npm-packages/#{pkg[:name]}/#{pkg[:name]}-*.tgz",
+        artifact_name: "npm-#{pkg[:name]}",
+        builder: pkg[:target],
+        rubies_cache_key: ruby_cache_keys[pkg[:build]]
+      }
+      # Run tests only if the package has 'test' script
+      package_json =
+        JSON.parse(
+          File.read("packages/npm-packages/#{pkg[:name]}/package.json")
+        )
+      if package_json["scripts"] && package_json["scripts"]["test"]
+        entry[:test] = "npm:#{pkg[:name]}-check"
+      end
+      entry
+    end
+  wapm_entries =
+    WAPM_PACKAGES.map do |pkg|
+      {
+        task: "wapm:#{pkg[:name]}-build",
+        artifact: "packages/wapm-packages/#{pkg[:name]}/dist",
+        artifact_name: "wapm-#{pkg[:name]}",
+        builder: "wasm32-unknown-wasi",
+        rubies_cache_key: ruby_cache_keys[pkg[:build]]
+      }
+    end
+  { build: build_entries, npm: npm_entries, wapm: wapm_entries }
+end
+
 namespace :ci do
   task :rake_task_matrix do
-    require "pathname"
-    ruby_cache_keys = {}
-    BUILD_TASKS.each { |build| ruby_cache_keys[build.name] = build.hexdigest }
-    entries =
-      BUILD_TASKS.map do |build|
-        {
-          task: "build:#{build.name}",
-          artifact:
-            Pathname
-              .new(build.crossruby.artifact)
-              .relative_path_from(LIB_ROOT)
-              .to_s,
-          artifact_name: File.basename(build.crossruby.artifact, ".tar.gz"),
-          builder: build.target,
-          rubies_cache_key: ruby_cache_keys[build.name]
-        }
-      end
-    entries +=
-      NPM_PACKAGES.map do |pkg|
-        entry = {
-          task: "npm:#{pkg[:name]}",
-          prerelease: "npm:configure_prerelease",
-          artifact: "packages/npm-packages/#{pkg[:name]}/#{pkg[:name]}-*.tgz",
-          artifact_name: "npm-#{pkg[:name]}",
-          builder: pkg[:target],
-          rubies_cache_key: ruby_cache_keys[pkg[:build]]
-        }
-        # Run tests only if the package has 'test' script
-        package_json =
-          JSON.parse(
-            File.read("packages/npm-packages/#{pkg[:name]}/package.json")
-          )
-        if package_json["scripts"] && package_json["scripts"]["test"]
-          entry[:test] = "npm:#{pkg[:name]}-check"
-        end
-        entry
-      end
-    entries +=
-      WAPM_PACKAGES.map do |pkg|
-        {
-          task: "wapm:#{pkg[:name]}-build",
-          artifact: "packages/wapm-packages/#{pkg[:name]}/dist",
-          artifact_name: "wapm-#{pkg[:name]}",
-          builder: "wasm32-unknown-wasi",
-          rubies_cache_key: ruby_cache_keys[pkg[:build]]
-        }
-      end
-    print JSON.generate(entries)
+    print JSON.generate(rake_task_matrix.flat_map { |_, entries| entries })
   end
 
   task :pin_build_manifest do
@@ -112,13 +106,15 @@ namespace :ci do
   desc "Fetch artifacts of a run of GitHub Actions"
   task :fetch_artifacts, [:run_id] do |t, args|
     RubyWasm::Toolchain.check_executable("gh")
-  
+
     artifacts =
       JSON.load(
         `gh api repos/{owner}/{repo}/actions/runs/#{args[:run_id]}/artifacts`
       )
+    matrix = rake_task_matrix.flat_map { |_, entries| entries }
+    release_artifacts = matrix.map { |entry| entry[:artifact_name] }
     artifacts =
-      artifacts["artifacts"].filter { RELASE_ARTIFACTS.include?(_1["name"]) }
+      artifacts["artifacts"].filter { release_artifacts.include?(_1["name"]) }
     mkdir_p "release"
     Dir.chdir("release") do
       artifacts.each do |artifact|
@@ -130,16 +126,17 @@ namespace :ci do
       end
     end
   end
-  
+
   desc "Publish artifacts as a GitHub Release"
   task :publish, [:tag] do |t, args|
     RubyWasm::Toolchain.check_executable("gh")
-  
+
     nightly = /^\d{4}-\d{2}-\d{2}-.$/.match?(args[:tag])
-    files =
-      RELASE_ARTIFACTS.flat_map { |artifact| Dir.glob("release/#{artifact}/*") }
+    matrix = rake_task_matrix
+    files = matrix.map { |entry| "release/#{entry[:artifact_name]}/*" }
     File.open("release/note.md", "w") { |f| f.print release_note }
-    NPM_RELEASE_ARTIFACTS.each do |artifact|
+    matrix[:npm].each do |task|
+      artifact = task[:artifact_name]
       tarball = Dir.glob("release/#{artifact}/*")
       next if tarball.empty?
       tarball = tarball[0]