Remove rake dependency from libyaml product

Author: kateinoigakukun

lib/ruby_wasm/build_system/product/crossruby.rb

@@ -130,7 +130,7 @@ def build_exts
     def build(remake: false, reconfigure: false)
       FileUtils.mkdir_p dest_dir
       FileUtils.mkdir_p build_dir
-      [@source, @baseruby].each(&:build)
+      [@source, @baseruby, @libyaml].each(&:build)
       dep_tasks.each(&:invoke)
       configure(reconfigure: reconfigure)
       build_exts
@@ -160,7 +160,6 @@ def ext_build_dir
 
     def with_libyaml(libyaml)
       @libyaml = libyaml
-      @dep_tasks << libyaml.install_task
     end
 
     def with_zlib(zlib)

lib/ruby_wasm/build_system/product/libyaml.rb

@@ -1,9 +1,8 @@
-require "rake"
 require_relative "./product"
 
 module RubyWasm
   class LibYAMLProduct < AutoconfProduct
-    attr_reader :target, :install_task
+    attr_reader :target
 
     LIBYAML_VERSION = "0.2.5"
 
@@ -29,23 +28,20 @@ def name
       product_build_dir
     end
 
-    def define_task
-      @install_task =
-        task name => [@toolchain.define_task] do
-          next if Dir.exist?(install_root)
+    def build
+      return if Dir.exist?(install_root)
 
-          mkdir_p File.dirname(product_build_dir)
-          rm_rf product_build_dir
-          sh "curl -L https://github.com/yaml/libyaml/releases/download/#{LIBYAML_VERSION}/yaml-#{LIBYAML_VERSION}.tar.gz | tar xz",
+      FileUtils.mkdir_p File.dirname(product_build_dir)
+      FileUtils.rm_rf product_build_dir
+      system "curl -L https://github.com/yaml/libyaml/releases/download/#{LIBYAML_VERSION}/yaml-#{LIBYAML_VERSION}.tar.gz | tar xz",
              chdir: File.dirname(product_build_dir)
 
-          # obtain the latest config.guess and config.sub for Emscripten and WASI triple support
-          sh "curl -o #{product_build_dir}/config/config.guess 'https://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD'"
-          sh "curl -o #{product_build_dir}/config/config.sub 'https://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD'"
+      # obtain the latest config.guess and config.sub for Emscripten and WASI triple support
+      system "curl -o #{product_build_dir}/config/config.guess 'https://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD'"
+      system "curl -o #{product_build_dir}/config/config.sub 'https://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD'"
 
-          sh "./configure #{configure_args.join(" ")}", chdir: product_build_dir
-          sh "make install DESTDIR=#{destdir}", chdir: product_build_dir
-        end
+      system "./configure #{configure_args.join(" ")}", chdir: product_build_dir
+      system "make install DESTDIR=#{destdir}", chdir: product_build_dir
     end
   end
 end

lib/ruby_wasm/rake_task.rb

@@ -43,8 +43,7 @@ def initialize(
     @toolchain =
       add_product (toolchain || RubyWasm::Toolchain.get(target, @build_dir))
 
-    @libyaml =
-      add_product RubyWasm::LibYAMLProduct.new(@build_dir, @target, @toolchain)
+    @libyaml = RubyWasm::LibYAMLProduct.new(@build_dir, @target, @toolchain)
     @zlib =
       add_product RubyWasm::ZlibProduct.new(@build_dir, @target, @toolchain)
     @wasi_vfs = add_product RubyWasm::WasiVfsProduct.new(@build_dir)