Include key aliases in error message

Author: anakinj

ext/openssl/ossl_pkey.c

@@ -498,7 +498,7 @@ add_parameter_to_builder(VALUE key, VALUE value, VALUE arg) {
             case OSSL_PARAM_UTF8_PTR:
             case OSSL_PARAM_OCTET_PTR:
                 OSSL_PARAM_BLD_free(params->param_bld);
-                ossl_raise(ePKeyError, "Unsupported parameter \"%s\", type is not implemented", key_ptr);
+                ossl_raise(ePKeyError, "Unsupported parameter \"%s\", handling of OSSL_PARAM_UTF8_PTR and OSSL_PARAM_OCTET_PTR not implemented", key_ptr);
                 break;
             }
 
@@ -517,6 +517,13 @@ add_parameter_to_builder(VALUE key, VALUE value, VALUE arg) {
         cur += snprintf(cur, end-cur, fmt, settable_params->key);
     }
 
+    for(size_t i = 0; i < params->nAliases; i++) {
+        const char *fmt = cur == message_buffer ? "%s" : ", %s";
+        if (cur > end)
+            break;
+        cur += snprintf(cur, end-cur, fmt, params->aliases[i].alias);
+    }
+
     ossl_raise(ePKeyError, "Invalid parameter \"%s\". Supported parameters: \"%s\"", key_ptr, message_buffer);
 }
 

test/openssl/test_pkey.rb

@@ -372,7 +372,7 @@ def test_s_from_parameters_ed25519
 
     def test_s_from_parameters_ed25519_with_invalid_parameters
       e = assert_raise(OpenSSL::PKey::PKeyError) { OpenSSL::PKey.from_parameters("ED25519", invalid: 12345) }
-      assert_equal 'Invalid parameter "invalid". Supported parameters: "pub, priv"', e.message
+      assert_equal 'Invalid parameter "invalid". Supported parameters: "pub, priv, pub_key, priv_key"', e.message
     end
   else
     def test_from_parameter_raises_on_pre_3_openssl