Add private?/public? methods and Marshal support to OpenSSL::PKey::PKey

Author: bdewater

ext/openssl/ossl_pkey.c

@@ -568,6 +568,25 @@ ossl_pkey_inspect(VALUE self)
                       OBJ_nid2sn(nid));
 }
 
+/*
+ *  call-seq:
+ *     key.private? => true or false
+ *
+ *  Returns whether this PKey instance has a private key. The private key can
+ *  be retrieved with PKey#private_to_{der,pem,raw}.
+ */
+static VALUE ossl_pkey_is_private(VALUE self)
+{
+    EVP_PKEY *pkey;
+    size_t len;
+
+    GetPKey(self, pkey);
+    len = EVP_PKEY_size(pkey);
+    unsigned char str[len];
+
+    return EVP_PKEY_get_raw_private_key(pkey, str, &len) == 1 ? Qtrue : Qfalse;
+}
+
 VALUE
 ossl_pkey_export_traditional(int argc, VALUE *argv, VALUE self, int to_der)
 {
@@ -708,6 +727,25 @@ ossl_pkey_export_spki(VALUE self, int to_der)
     return ossl_membio2str(bio);
 }
 
+/*
+ *  call-seq:
+ *     key.public? => true or false
+ *
+ *  Returns whether this PKey instance has a public key. The public key can
+ *  be retrieved with PKey#public_to_{der,pem,raw}.
+ */
+static VALUE ossl_pkey_is_public(VALUE self)
+{
+    EVP_PKEY *pkey;
+    size_t len;
+
+    GetPKey(self, pkey);
+    len = EVP_PKEY_size(pkey);
+    unsigned char str[len];
+
+    return EVP_PKEY_get_raw_public_key(pkey, str, &len) == 1 ? Qtrue : Qfalse;
+}
+
 /*
  * call-seq:
  *    pkey.public_to_der -> string
@@ -1027,8 +1065,10 @@ Init_ossl_pkey(void)
     rb_define_method(cPKey, "initialize", ossl_pkey_initialize, 0);
     rb_define_method(cPKey, "oid", ossl_pkey_oid, 0);
     rb_define_method(cPKey, "inspect", ossl_pkey_inspect, 0);
+    rb_define_method(cPKey, "private?", ossl_pkey_is_private, 0);
     rb_define_method(cPKey, "private_to_der", ossl_pkey_private_to_der, -1);
     rb_define_method(cPKey, "private_to_pem", ossl_pkey_private_to_pem, -1);
+    rb_define_method(cPKey, "public?", ossl_pkey_is_public, 0);
     rb_define_method(cPKey, "public_to_der", ossl_pkey_public_to_der, 0);
     rb_define_method(cPKey, "public_to_pem", ossl_pkey_public_to_pem, 0);
 

lib/openssl/pkey.rb

@@ -69,6 +69,20 @@ def to_bn(conversion_form = group.point_conversion_form)
   end
   end
 
+  class PKey
+    def self._load(string)
+      OpenSSL::PKey.read(string)
+    end
+
+    def _dump(_level)
+      if private?
+        private_to_der
+      else
+        public_to_der
+      end
+    end
+  end
+
   class RSA
     include OpenSSL::Marshal
   end

test/openssl/test_pkey.rb

@@ -103,8 +103,18 @@ def test_ed25519
     assert_instance_of OpenSSL::PKey::PKey, priv
     assert_instance_of OpenSSL::PKey::PKey, pub
     assert_equal priv_pem, priv.private_to_pem
+    assert_equal true, priv.private?
+    assert_equal true, priv.public?
+    priv_deserialized = Marshal.load(Marshal.dump(priv))
+    assert_equal priv.private_to_der, priv_deserialized.private_to_der
+
     assert_equal pub_pem, priv.public_to_pem
     assert_equal pub_pem, pub.public_to_pem
+    assert_equal false, pub.private?
+    assert_equal true, pub.public?
+    pub_deserialized = Marshal.load(Marshal.dump(pub))
+    assert_equal pub.public_to_der, pub_deserialized.public_to_der
+
 
     sig = [<<~EOF.gsub(/[^0-9a-f]/, "")].pack("H*")
     92a009a9f0d4cab8720e820b5f642540
@@ -150,5 +160,9 @@ def test_x25519
     assert_equal alice_pem, alice.private_to_pem
     assert_equal bob_pem, bob.public_to_pem
     assert_equal [shared_secret].pack("H*"), alice.derive(bob)
+    alice_deserialized = Marshal.load(Marshal.dump(alice))
+    assert_equal alice.private_to_der, alice_deserialized.private_to_der
+    bob_deserialized = Marshal.load(Marshal.dump(bob))
+    assert_equal bob.public_to_der, bob_deserialized.public_to_der
   end
 end