Skip to content

Commit 362a69a

Browse files
authored
Merge pull request #747 from botovq/csr-version
Only CSR version 1 (encoded as 0) is allowed by PKIX standards
2 parents 44fd820 + c06fdeb commit 362a69a

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

test/openssl/test_x509req.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ def test_version
3939
assert_equal(0, req.version)
4040
req = OpenSSL::X509::Request.new(req.to_der)
4141
assert_equal(0, req.version)
42-
43-
req = issue_csr(1, @dn, @rsa1024, OpenSSL::Digest.new('SHA256'))
44-
assert_equal(1, req.version)
45-
req = OpenSSL::X509::Request.new(req.to_der)
46-
assert_equal(1, req.version)
4742
end
4843

4944
def test_subject
@@ -106,7 +101,7 @@ def test_sign_and_verify_rsa_sha1
106101
assert_equal(false, req.verify(@rsa2048))
107102
assert_equal(false, request_error_returns_false { req.verify(@dsa256) })
108103
assert_equal(false, request_error_returns_false { req.verify(@dsa512) })
109-
req.version = 1
104+
req.subject = OpenSSL::X509::Name.parse("/C=JP/CN=FooBarFooBar")
110105
assert_equal(false, req.verify(@rsa1024))
111106
rescue OpenSSL::X509::RequestError # RHEL 9 disables SHA1
112107
end

0 commit comments

Comments
 (0)