Merge pull request #569 from davishmcclurg/promise-exception

Reject promise on any exception

Author: jdantonio

lib/concurrent/promise.rb

@@ -525,7 +525,7 @@ def complete(success, value, reason)
     # @!visibility private
     def realize(task)
       @executor.post do
-        success, value, reason = SafeTaskExecutor.new(task).execute(*@args)
+        success, value, reason = SafeTaskExecutor.new(task, rescue_exception: true).execute(*@args)
         complete(success, value, reason)
       end
     end

spec/concurrent/promise_spec.rb

@@ -620,6 +620,11 @@ def get_ivar_from_args(opts)
         expect(p.reason).to be_a ArgumentError
       end
 
+      it 'rejects on Exception' do
+        p = Promise.new(executor: :immediate){ raise Exception }.execute
+        expect(p).to be_rejected
+      end
+
     end
 
     context 'aliases' do