Refactored more specs.

Author: jdantonio

spec/concurrent/future_spec.rb

@@ -57,7 +57,7 @@ def execute_dereferenceable(subject)
     end
 
     context 'subclassing' do
-      
+
       subject{ Future.execute(executor: executor){ 42 } }
 
       it 'protects #set' do
@@ -75,7 +75,7 @@ def execute_dereferenceable(subject)
 
     context '#initialize' do
 
-        let(:executor) { ImmediateExecutor.new }
+      let(:executor) { ImmediateExecutor.new }
 
       it 'sets the state to :unscheduled' do
         Future.new(executor: executor){ nil }.should be_unscheduled
@@ -111,6 +111,7 @@ def execute_dereferenceable(subject)
     context 'instance #execute' do
 
       it 'does nothing unless the state is :unscheduled' do
+        executor = ImmediateExecutor.new
         executor.should_not_receive(:post).with(any_args)
         future = Future.new(executor: executor){ nil }
         future.instance_variable_set(:@state, :pending)

spec/concurrent/promise_spec.rb

@@ -125,9 +125,9 @@ module Concurrent
       describe 'with children' do
 
         let(:root) { Promise.new(executor: executor){ sleep(0.1); nil } }
-        let(:c1) { root.then { nil } }
-        let(:c2) { root.then { nil } }
-        let(:c2_1) { c2.then { nil } }
+        let(:c1) { root.then { sleep(0.1); nil } }
+        let(:c2) { root.then { sleep(0.1); nil } }
+        let(:c2_1) { c2.then { sleep(0.1); nil } }
 
         context 'when called on the root' do
           it 'should set all promises to :pending' do
@@ -142,7 +142,6 @@ module Concurrent
 
         context 'when called on a child' do
           it 'should set all promises to :pending' do
-            pending('intermittently failing')
             c2_1.execute
 
             [root, c1, c2, c2_1].each { |p| p.should be_pending }
@@ -336,8 +335,7 @@ module Concurrent
       end
 
       it 'uses reason as rejection reason when a promise has no rescue callable' do
-        pending('intermittently failing')
-        p = Promise.new(executor: executor){ raise ArgumentError }.then { |val| val }.execute
+        p = Promise.new(executor: ImmediateExecutor.new){ raise ArgumentError }.then{ |val| val }.execute
         sleep(0.1)
         p.should be_rejected
         p.reason.should be_a ArgumentError

spec/concurrent/thread_pool_executor_shared.rb

@@ -145,8 +145,7 @@
     end
 
     it 'returns :max_length when stopped' do
-      pending('intermittently failing')
-      100.times{ subject.post{ sleep(0.5) } }
+      100.times{ subject.post{ nil } }
       sleep(0.1)
       subject.shutdown
       subject.wait_for_termination(1)