fixed CyclicBarrier#wait return value on reset

Author: mighe

lib/concurrent/atomic/cyclic_barrier.rb

@@ -36,7 +36,7 @@ def number_waiting
     # Blocks on the barrier until the number of waiting threads is equal to `parties` or until `timeout` is reached or `reset` is called
     # If a block has been passed to the constructor, it will be executed once by the last arrived thread before releasing the others
     # @param [Fixnum] timeout the number of seconds to wait for the counter or `nil` to block indefinitely
-    # @return [Boolean] `true` if the `count` reaches zero else false on `timeout` or on `reset` or on broken event
+    # @return [Boolean] `true` if the `count` reaches zero else false on `timeout` or on `reset` or if the barrier is broken
     def wait(timeout = nil)
       @mutex.synchronize do
 
@@ -60,7 +60,7 @@ def wait(timeout = nil)
           end
 
           if remaining.woken_up?
-            return true
+            return generation.status == :fulfilled
           else
             generation.status = :broken
             @condition.broadcast

spec/concurrent/atomic/cyclic_barrier_spec.rb

@@ -120,6 +120,15 @@ module Concurrent
           parties.times { Thread.new { barrier.wait; latch.count_down } }
           latch.wait(0.1).should be_true
         end
+
+        it 'return false if barrier has been reset' do
+          latch = CountDownLatch.new(1)
+
+          Thread.new { latch.count_down if barrier.wait == false }
+          sleep(0.1)
+          barrier.reset
+          latch.wait(0.1).should be_true
+        end
       end
 
       context 'with timeout' do