AtomicMarkableReference: update try_update/try_update! APIs

Author: ianks

lib/concurrent/edge/atomic_markable_reference.rb

@@ -47,11 +47,7 @@ def compare_and_set(expected_val, new_val, expected_mark, new_mark)
 
         prospect = ImmutableArray[new_val, new_mark]
 
-        # If we guarantee internally that `current` will never be a Numeric, we
-        # can skip a type check in `compare_and_set` and directly call
-        # `_compare_and_set`. This is possible since we always internally wrap
-        # the users `value` and `mark` in an ImmutableArray.
-        @Reference._compare_and_set current, prospect
+        @Reference.compare_and_set current, prospect
       end
       alias_method :compare_and_swap, :compare_and_set
 
@@ -119,7 +115,7 @@ def update
         end
       end
 
-      # @!macro [attach] atomic_markable_reference_method_try_update
+      # @!macro [attach] atomic_markable_reference_method_try_update!
       #
       # Pass the current value to the given block, replacing it
       # with the block's result. Raise an exception if the update
@@ -133,7 +129,7 @@ def update
       # @return [ImmutableArray] the new value and marked state
       #
       # @raise [Concurrent::ConcurrentUpdateError] if the update fails
-      def try_update
+      def try_update!
         old_val, old_mark = @Reference.get
         new_val, new_mark = yield old_val, old_mark
 
@@ -147,7 +143,7 @@ def try_update
         ImmutableArray[new_val, new_mark]
       end
 
-      # @!macro [attach] atomic_markable_reference_method_try_update_no_exception
+      # @!macro [attach] atomic_markable_reference_method_try_update
       #
       # Pass the current value to the given block, replacing it with the
       # block's result. Simply return nil if update fails.
@@ -159,7 +155,7 @@ def try_update
       #
       # @return [ImmutableArray] the new value and marked state, or nil if
       # the update failed
-      def try_update_no_exception
+      def try_update
         old_val, old_mark = @Reference.get
         new_val, new_mark = yield old_val, old_mark
 

spec/concurrent/atomic/atomic_markable_reference_spec.rb

@@ -26,9 +26,9 @@
     end
   end
 
-  describe '#try_update' do
+  describe '#try_update!' do
     it 'updates the value and mark' do
-      val, mark = subject.try_update { |v, m| [v + 1, !m] }
+      val, mark = subject.try_update! { |v, m| [v + 1, !m] }
 
       expect(subject.value).to eq 1001
       expect(val).to eq 1001
@@ -37,15 +37,15 @@
 
     it 'raises ConcurrentUpdateError when attempting to set inside of block' do
       expect do
-        subject.try_update do |v, m|
+        subject.try_update! do |v, m|
           subject.set(1001, false)
           [v + 1, !m]
         end
       end.to raise_error Concurrent::ConcurrentUpdateError
     end
   end
 
-  describe '#try_update_no_exception' do
+  describe '#try_update' do
     it 'updates the value and mark' do
       val, mark = subject.try_update { |v, m| [v + 1, !m] }