Run each spec file in a process to detect missing requires

* Fixes #934.

Author: eregon

.github/workflows/ci.yml

@@ -1,5 +1,8 @@
 name: CI
 on: [push, pull_request]
+concurrency:
+  group: ${{ github.ref }}
+  cancel-in-progress: true
 
 jobs:
   build:
@@ -26,3 +29,17 @@ jobs:
         bundler-cache: true
     - name: Run tests
       run: bundle exec rake ci
+
+  isolated:
+    name: "Test isolated"
+    runs-on: ubuntu-latest
+    env:
+      RUBYOPT: '-w'
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.2
+          bundler-cache: true
+      - run: bundle exec rake compile
+      - run: bundle exec rake spec:isolated

Gemfile

@@ -2,7 +2,6 @@ source 'https://rubygems.org'
 
 require File.join(File.dirname(__FILE__), 'lib/concurrent-ruby/concurrent/version')
 require File.join(File.dirname(__FILE__ ), 'lib/concurrent-ruby-edge/concurrent/edge/version')
-require File.join(File.dirname(__FILE__ ), 'lib/concurrent-ruby/concurrent/utility/engine')
 
 no_path = ENV['NO_PATH']
 options = no_path ? {} : { path: '.' }

Rakefile

@@ -91,6 +91,19 @@ begin
   desc 'executed in CI'
   task :ci => [:compile, 'spec:ci']
 
+  desc 'run each spec file in a separate process to help find missing requires'
+  task 'spec:isolated' do
+    glob = "#{ENV['DIR'] || 'spec'}/**/*_spec.rb"
+    from = ENV['FROM']
+    env = { 'ISOLATED' => 'true' }
+    Dir[glob].each do |spec|
+      next if from and from != spec
+      from = nil if from == spec
+
+      sh env, 'rspec', spec
+    end
+  end
+
   task :default => [:clobber, :compile, :spec]
 rescue LoadError => e
   puts 'RSpec is not installed, skipping test task definitions: ' + e.message

concurrent-ruby.gemspec

@@ -1,5 +1,4 @@
 require File.join(File.dirname(__FILE__ ), 'lib/concurrent-ruby/concurrent/version')
-require File.join(File.dirname(__FILE__ ), 'lib/concurrent-ruby/concurrent/utility/engine')
 
 Gem::Specification.new do |s|
   git_files = `git ls-files`.split("\n")

docs-source/actor/format.rb

@@ -13,7 +13,7 @@
 input_paths.each_with_index do |input_path, i|
 
   pid = fork do
-    require File.join(root, 'init.rb')
+    require_relative 'init'
 
     begin
       output_path = input_path.gsub /\.in\.rb$/, '.out.rb'

docs-source/tvar.md

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "benchmark"
-require "concurrent"
+require 'benchmark'
+require 'concurrent'
 
 hash  = {}
 map = Concurrent::Map.new

examples/benchmark_map.rb

@@ -12,7 +12,7 @@
 input_paths.each_with_index do |input_path, i|
 
   pid = fork do
-    require_relative 'init.rb'
+    require_relative 'init'
 
     begin
       output_path = input_path.gsub /\.in\.rb$/, '.out.rb'

examples/format.rb

@@ -1,6 +1,7 @@
+# NOTE: finer grained than require 'concurrent/actor' not supported
+
 require 'concurrent/configuration'
 require 'concurrent/executor/serialized_execution'
-require 'concurrent/synchronization'
 require 'concurrent/edge/promises'
 
 module Concurrent

lib/concurrent-ruby-edge/concurrent/actor.rb

@@ -1,4 +1,4 @@
-require 'concurrent/synchronization'
+require 'concurrent/synchronization/object'
 require 'concurrent/utility/monotonic_time'
 
 module Concurrent