Addressed more intermittently failing specs.

Author: jdantonio

spec/concurrent/executor/global_thread_pool_shared.rb

@@ -15,19 +15,21 @@
     end
 
     it 'calls the block with the given arguments' do
-      @expected = nil
+      latch = Concurrent::CountDownLatch.new(1)
+      expected = nil
       subject.post(1, 2, 3) do |a, b, c|
-        @expected = a + b + c
+        expected = [a, b, a]
+        latch.count_down
       end
-      sleep(0.1)
-      @expected.should eq 6
+      latch.wait(0.2)
+      expected.should eq [1, 2, 3]
     end
 
     it 'aliases #<<' do
-      @expected = false
-      subject << proc { @expected = true }
-      sleep(0.1)
-      @expected.should be_true
+      latch = Concurrent::CountDownLatch.new(1)
+      subject << proc { latch.count_down }
+      latch.wait(0.2)
+      latch.count.should eq 0
     end
   end
 end

spec/concurrent/scheduled_task_spec.rb

@@ -222,10 +222,15 @@ def execute_dereferenceable(subject)
           attr_reader :value
           attr_reader :reason
           attr_reader :count
-          define_method(:update) do |time, value, reason|
+          attr_reader :latch
+          def initialize
+            @latch = Concurrent::CountDownLatch.new(1)
+          end
+          def update(time, value, reason)
             @count = @count.to_i + 1
             @value = value
             @reason = reason
+            @latch.count_down
           end
         end
       end
@@ -269,17 +274,15 @@ def execute_dereferenceable(subject)
       it 'notifies all observers on fulfillment' do
         task = ScheduledTask.new(0.1){ 42 }.execute
         task.add_observer(observer)
-        task.value(1).should == 42
-        task.reason.should be_nil
+        observer.latch.wait(1)
         observer.value.should == 42
         observer.reason.should be_nil
       end
 
       it 'notifies all observers on rejection' do
         task = ScheduledTask.new(0.1){ raise StandardError }.execute
         task.add_observer(observer)
-        task.value(1).should be_nil
-        task.reason.should be_a(StandardError)
+        observer.latch.wait(1)
         observer.value.should be_nil
         observer.reason.should be_a(StandardError)
       end