changed AtomicBoolean#make_true and #make_false to return a boolean indicating whether the value has been updated or not

Author: mighe

lib/concurrent/atomic/atomic_boolean.rb

@@ -75,24 +75,28 @@ def false?
     #
     #   Explicitly sets the value to true.
     #
-    #   @return [nil]
+    #   @return [Boolean] true is value has changed, otherwise false
     def make_true
       @mutex.lock
+      old = @value
       @value = true
       @mutex.unlock
-      nil
+
+      !old
     end
 
     # @!macro [attach] atomic_boolean_method_make_false
     #
     #   Explicitly sets the value to false.
     #
-    #   @return [nil]
+    #   @return [Boolean] true is value has changed, otherwise false
     def make_false
       @mutex.lock
+      old = @value
       @value = false
       @mutex.unlock
-      nil
+
+      old
     end
   end
 
@@ -131,12 +135,12 @@ def false?
 
       # @!macro atomic_boolean_method_make_true
       def make_true
-        @atomic.set(true)
+        @atomic.compareAndSet(false, true)
       end
 
       # @!macro atomic_boolean_method_make_false
       def make_false
-        @atomic.set(false)
+        @atomic.compareAndSet(true, false)
       end
     end
 

spec/concurrent/atomic/atomic_boolean_spec.rb

@@ -75,30 +75,30 @@
 
   describe '#make_true' do
 
-    it 'makes a false value true and returns nil' do
+    it 'makes a false value true and returns true' do
       subject = described_class.new(false)
-      subject.make_true.should be_nil
+      subject.make_true.should be_true
       subject.value.should be_true
     end
 
-    it 'keeps a true value true and returns nil' do
+    it 'keeps a true value true and returns false' do
       subject = described_class.new(true)
-      subject.make_true.should be_nil
+      subject.make_true.should be_false
       subject.value.should be_true
     end
   end
 
   describe '#make_false' do
 
-    it 'makes a true value false and returns nil' do
+    it 'makes a true value false and returns true' do
       subject = described_class.new(true)
-      subject.make_false.should be_nil
+      subject.make_false.should be_true
       subject.value.should be_false
     end
 
-    it 'keeps a false value false and returns nil' do
+    it 'keeps a false value false and returns false' do
       subject = described_class.new(false)
-      subject.make_false.should be_nil
+      subject.make_false.should be_false
       subject.value.should be_false
     end
   end