Skip to content

Commit 16a88ff

Browse files
committed
clean up a few warnings
The bare `*` is ambiguous, so I added parens to make it unambiguous. Also I removed some unused assignments. I don't know how to turn on warnings for RSpec, so I just ran the tests like this: ``` RUBYOPT=-w be rake spec ```
1 parent 0c75e79 commit 16a88ff

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

lib/concurrent/channel/buffer/timer.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ def do_poll
6262

6363
if Concurrent.monotonic_time > @tick
6464
# only one listener gets notified
65-
closed = empty = true
6665
return :tick, Concurrent::Channel::Tick.new(@tick)
6766
else
6867
return :wait, true

lib/concurrent/edge/atomic_markable_reference.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ module Edge
1111
# @api Edge
1212
class AtomicMarkableReference < ::Concurrent::Synchronization::Object
1313

14-
private *attr_volatile_with_cas(:reference)
14+
private(*attr_volatile_with_cas(:reference))
1515

1616
# @!macro [attach] atomic_markable_reference_method_initialize
1717
def initialize(value = nil, mark = false)

lib/concurrent/edge/lock_free_stack.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def next_node
2323

2424
EMPTY = Empty[nil, nil]
2525

26-
private *attr_volatile_with_cas(:head)
26+
private(*attr_volatile_with_cas(:head))
2727

2828
def initialize
2929
super(EMPTY)

0 commit comments

Comments
 (0)