Merge pull request #175 from ruby-concurrency/actress

Forbid ImmediateExecutor for Actors

Author: Petr Chalupa

lib/concurrent/actor.rb

@@ -70,7 +70,7 @@ def self.spawn(*args, &block)
       if Actor.current
         Core.new(spawn_optionify(*args).merge(parent: Actor.current), &block).reference
       else
-        root.ask([:spawn, spawn_optionify(*args), block]).value
+        root.ask([:spawn, spawn_optionify(*args), block]).value!
       end
     end
 

lib/concurrent/actor/core.rb

@@ -46,10 +46,14 @@ def initialize(opts = {}, &block)
         synchronize do
           @mailbox              = Array.new
           @serialized_execution = SerializedExecution.new
-          @executor             = Type! opts.fetch(:executor, Concurrent.configuration.global_task_pool), Executor
           @children             = Set.new
-          @context_class        = Child! opts.fetch(:class), AbstractContext
+
+          @context_class = Child! opts.fetch(:class), AbstractContext
           allocate_context
+
+          @executor = Type! opts.fetch(:executor, Concurrent.configuration.global_task_pool), Executor
+          raise ArgumentError, 'ImmediateExecutor is not supported' if @executor.is_a? ImmediateExecutor
+
           @reference = (Child! opts[:reference_class] || @context.default_reference_class, Reference).new self
           @name      = (Type! opts.fetch(:name), String, Symbol).to_s
 
@@ -82,7 +86,7 @@ def initialize(opts = {}, &block)
                 handle_envelope Envelope.new(message, nil, parent, reference)
               end
 
-              initialized.set true if initialized
+              initialized.set reference if initialized
             rescue => ex
               log ERROR, ex
               @first_behaviour.terminate!

spec/concurrent/actor_spec.rb

@@ -54,6 +54,10 @@ def on_message(message)
       #   set_trace_func nil
       # end
 
+      it 'forbids Immediate executor' do
+        expect { Utils::AdHoc.spawn name: 'test', executor: ImmediateExecutor.new }.to raise_error
+      end
+
       describe 'stress test' do
         1.times do |i|
           it format('run %3d', i) do