fixup! Small adjustments to make the move to RSpecRails

Author: pirj

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+- Add a cop that makes `Timecop` illegal, in favour of `ActiveSupport::Testing::TimeHelpers`. ([@sambostock])
+
 ## 2.30.0 (2024-06-12)
 
 - Fix an runtime error for rubocop-rspec +3.0. ([@bquorning])
@@ -79,6 +81,7 @@
 [@paydaylight]: https://github.com/paydaylight
 [@pirj]: https://github.com/pirj
 [@r7kamura]: https://github.com/r7kamura
+[@sambostock]: https://github.com/sambostock
 [@splattael]: https://github.com/splattael
 [@tmaier]: https://github.com/tmaier
 [@ydah]: https://github.com/ydah

config/default.yml

@@ -77,6 +77,13 @@ RSpecRails/NegationBeValid:
   VersionChanged: '2.29'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec_rails/RuboCop/Cop/RSpecRails/NegationBeValid
 
+RSpecRails/Timecop:
+  Description: Enforces use of `ActiveSupport::Testing::TimeHelpers` instead of `Timecop`.
+  Enabled: pending
+  VersionAdded: "<<next>>"
+  SafeAutoCorrect: false
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec_rails/RuboCop/Cop/RSpecRails/Timecop
+
 RSpecRails/TravelAround:
   Description: Prefer to travel in `before` rather than `around`.
   Enabled: pending

lib/rubocop/cop/rails/timecop.rb renamed to lib/rubocop/cop/rspec_rails/timecop.rb

@@ -2,9 +2,8 @@
 
 module RuboCop
   module Cop
-    module Rails
-      # Disallows all usage of `Timecop`, in favour of
-      # `ActiveSupport::Testing::TimeHelpers`.
+    module RSpecRails
+      # Enforces use of `ActiveSupport::Testing::TimeHelpers` instead of `Timecop`.
       #
       # ## Migration
       # `Timecop.freeze` should be replaced with `freeze_time` when used
@@ -93,7 +92,7 @@ module Rails
       #   travel_to(time)
       #   travel(duration) { assert true }
       #   travel_to(time) { assert true }
-      class Timecop < Base
+      class Timecop < ::RuboCop::Cop::Base
         extend AutoCorrector
 
         FREEZE_MESSAGE = 'Use `%<replacement>s` instead of `Timecop.freeze`'

lib/rubocop/cop/rspec_rails_cops.rb

@@ -6,4 +6,5 @@
 require_relative 'rspec_rails/inferred_spec_type'
 require_relative 'rspec_rails/minitest_assertions'
 require_relative 'rspec_rails/negation_be_valid'
+require_relative 'rspec_rails/timecop'
 require_relative 'rspec_rails/travel_around'

spec/rubocop/cop/rails/timecop_spec.rb renamed to spec/rubocop/cop/rspec_rails/timecop_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe RuboCop::Cop::Rails::Timecop, :config do
+RSpec.describe RuboCop::Cop::RSpecRails::Timecop, :config do
   shared_examples 'adds an offense to constant, and does not correct' do |usage:|
     constant = usage.include?('::Timecop') ? '::Timecop' : 'Timecop'