Fix RSpec/ChangeByZero cop to handle invalid change matcher usage

issue number: #2069

Author: rito.ishihara

CHANGELOG.md

@@ -5,6 +5,7 @@
 - Fix false positive in `RSpec/Pending`, where it would mark the default block `it` as an offense. ([@bquorning])
 - Fix issue when `Style/ContextWording` is configured with a Prefix being interpreted as a boolean, like `on`. ([@sakuro])
 - Add new `RSpec/IncludeExamples` cop to enforce using `it_behaves_like` over `include_examples`. ([@dvandersluis])
+- Fix `RSpec/ChangeByZero` cop error when analyzing invalid change matcher syntax. ([@rito])
 
 ## 3.5.0 (2025-02-16)
 
@@ -1041,6 +1042,7 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@rolfschmidt]: https://github.com/rolfschmidt
 [@rrosenblum]: https://github.com/rrosenblum
 [@rspeicher]: https://github.com/rspeicher
+[@rito]: https://github.com/Lee266
 [@rst-j]: https://github.com/RST-J
 [@sakuro]: https://github.com/sakuro
 [@samrjenkins]: https://github.com/samrjenkins

lib/rubocop/cop/rspec/change_by_zero.rb

@@ -102,6 +102,10 @@ def on_send(node)
         private
 
         def register_offense(node, change_node)
+          if !node.parent.respond_to?(:send_type?) || !node.parent.send_type?
+            return
+          end
+
           if compound_expectations?(node)
             add_offense(node,
                         message: message_compound(change_node)) do |corrector|
@@ -116,8 +120,7 @@ def register_offense(node, change_node)
         end
 
         def compound_expectations?(node)
-          node.parent.send_type? &&
-            %i[and or & |].include?(node.parent.method_name)
+          %i[and or & |].include?(node.parent.method_name)
         end
 
         def message(change_node)

spec/rubocop/cop/rspec/change_by_zero_spec.rb

@@ -365,5 +365,12 @@
         expect { foo }.to change { Foo.bar }.by(1)
       end
     RUBY
+
+    expect_no_offenses(<<~RUBY)
+      it do
+        subject; change(Foo, :bar).by(0)
+        change(foo, :bar).by(0)
+      end
+    RUBY
   end
 end