Fix a false positive for RSpec/DescribedClass when SkipBlocks is true and numblocks are used

Author: Earlopain

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Add new `RSpec/IncludeExamples` cop to enforce using `it_behaves_like` over `include_examples`. ([@dvandersluis])
 - Change `RSpec/ScatteredSetup` to allow `around` hooks to be scattered. ([@ydah])
 - Fix an error `RSpec/ChangeByZero` cop when without expect block. ([@lee266])
+- Fix a false positive for `RSpec/DescribedClass` when `SkipBlocks` is true and numblocks are used. ([@earlopain])
 
 ## 3.5.0 (2025-02-16)
 

lib/rubocop/cop/rspec/described_class.rb

@@ -153,7 +153,9 @@ def scope_change?(node)
         end
 
         def skippable_block?(node)
-          node.block_type? && !rspec_block?(node) && cop_config['SkipBlocks']
+          return false unless cop_config['SkipBlocks']
+
+          node.any_block_type? && !rspec_block?(node)
         end
 
         def only_static_constants?

spec/rubocop/cop/rspec/described_class_spec.rb

@@ -10,7 +10,7 @@
       expect_offense(<<~RUBY)
         describe MyClass do
           controller(ApplicationController) do
-            bar = MyClass
+            self.bar = MyClass
           end
 
           before do
@@ -27,7 +27,7 @@
       expect_correction(<<~RUBY)
         describe MyClass do
           controller(ApplicationController) do
-            bar = MyClass
+            self.bar = MyClass
           end
 
           before do
@@ -40,6 +40,27 @@
         end
       RUBY
     end
+
+    it 'ignores offenses within non-rspec numblocks' do
+      expect_offense(<<~RUBY)
+        describe MyClass do
+          controller(ApplicationController) do
+            do_some_work(_1)
+            self.bar = MyClass
+          end
+
+          before do
+            MyClass
+            ^^^^^^^ Use `described_class` instead of `MyClass`.
+
+            Foo.custom_block do
+              do_some_work(_1)
+              MyClass
+            end
+          end
+        end
+      RUBY
+    end
   end
 
   context 'when SkipBlocks is `false`' do