Fix bug where error message is missing info at the end (#288)

* Fix bug where error message is missing info at the end
Enable UP rules

* Revert bad TOML sort.

Author: nathanjmcdougall

pins/boards.py

@@ -81,7 +81,7 @@ def pin_versions(self, name: str, as_df: bool = True) -> Sequence[VersionRaw]:
         """
 
         if not self.pin_exists(name):
-            raise PinsError("Cannot check version, since pin %s does not exist" % name)
+            raise PinsError(f"Cannot check version, since pin {name} does not exist")
 
         detail = isinstance(self, BoardRsConnect)
 
@@ -548,7 +548,7 @@ def pin_delete(self, names: "str | Sequence[str]"):
 
         for name in names:
             if not self.pin_exists(name):
-                raise PinsError("Cannot delete pin, since pin %s does not exist" % name)
+                raise PinsError(f"Cannot delete pin, since pin {name} does not exist")
 
             path_to_pin = self.construct_path([self.path_to_pin(name)])
             self.fs.rm(path_to_pin, recursive=True)

pins/meta.py

@@ -205,7 +205,7 @@ def get_meta_name(self, *args, **kwargs) -> str:
 
     def get_version_for_meta(self, api_version) -> Version:
         if api_version != 1:
-            raise NotImplementedError("Unsupported api_version: %s" % api_version)
+            raise NotImplementedError(f"Unsupported api_version: {api_version}")
 
         return Version
 

pins/rsconnect/api.py

@@ -198,9 +198,7 @@ def _validate_delete_response(self, r):
             self._validate_json_response(data)
 
             # this should never be triggered
-            raise ValueError(
-                "Unknown json returned by delete_content endpoint: %s" % data
-            )
+            raise ValueError(f"Unknown json returned by delete_content endpoint: {data}")
         except requests.JSONDecodeError:
             # fallback to at least raising status errors
             r.raise_for_status()

pins/tests/test_versions.py

@@ -4,6 +4,7 @@
 import pytest
 import xxhash
 
+from pins.errors import PinsVersionError
 from pins.versions import Version
 
 EXAMPLE_DATE = datetime(2021, 1, 2, 13, 58, 59)
@@ -20,6 +21,11 @@ def test_version_from_string():
     assert version.hash == "baf3f"
 
 
+def test_version_from_string_baddate():
+    with pytest.raises(PinsVersionError, match="Invalid date part of version: bug"):
+        Version.from_string("bug-baf3f")
+
+
 def test_version_hash_file(bytes_):
     f_bytes, digest = bytes_
     assert Version.hash_file(f_bytes) == digest

pins/versions.py

@@ -69,7 +69,7 @@ def from_string(cls, version: str) -> "Version":
 
         if len(parts) != 2:
             raise PinsVersionError(
-                "version string can only have 1 '-', but contains %s" % len(parts)
+                f"version string can only have 1 '-', but contains {len(parts) - 1}"
             )
 
         dt_string, hash_ = parts
@@ -79,7 +79,7 @@ def from_string(cls, version: str) -> "Version":
         try:
             created = cls.parse_created(dt_string)
         except ValueError:
-            raise PinsVersionError("Invalid date part of version: " % dt_string)
+            raise PinsVersionError(f"Invalid date part of version: {dt_string}")
 
         obj = cls(created, hash_)
 

pyproject.toml

@@ -120,5 +120,13 @@ line-length = 90
 extend-exclude = ["docs"]
 
 [tool.ruff.lint]
-select = ["E", "F", "I", "W"]
-ignore = ["E501"]
+select = [
+    "E",  # Style
+    "F",  # Errors
+    "I",  # Import sorting
+    "UP", # Upgrade to latest supported Python syntax
+    "W",  # Style
+]
+ignore = [
+    "E501", # Line too long
+]