test failure messages better

Author: skatkov

lib/rspec/rails/matchers/have_reported_error.rb

@@ -69,10 +69,10 @@ def description
 
         def failure_message
           if !@error_subscriber.events.empty? && !@attributes.empty?
-            event_data = @error_subscriber.events.last[1].with_indifferent_access
-            unmatched = unmatched_attributes(event_data["context"])
+            event_context = @error_subscriber.events.last[1].with_indifferent_access["context"]
+            unmatched = unmatched_attributes(event_context)
             unless unmatched.empty?
-              return "Expected error attributes to match #{@attributes}, but got these mismatches: #{unmatched} and actual values are #{event_data}"
+              return "Expected error attributes to match #{@attributes}, but got these mismatches: #{unmatched} and actual values are #{event_context}"
             end
           elsif @error_subscriber.events.empty?
             return 'Expected the block to report an error, but none was reported.'
@@ -94,13 +94,9 @@ def failure_message
 
         def failure_message_when_negated
           error_count = @error_subscriber.events.count
-          if defined?(ActiveSupport::Inflector)
-            error_word = 'error'.pluralize(error_count)
-            verb = error_count == 1 ? 'has' : 'have'
-          else
-            error_word = error_count == 1 ? 'error' : 'errors'
-            verb = error_count == 1 ? 'has' : 'have'
-          end
+          error_word = 'error'.pluralize(error_count)
+          verb = error_count == 1 ? 'has' : 'have'
+
           "Expected the block not to report any errors, but #{error_count} #{error_word} #{verb} been reported."
         end
 
@@ -129,8 +125,8 @@ def attributes_match_if_specified?
           return true if @attributes.empty?
           return false if @error_subscriber.events.empty?
 
-          event_data = @error_subscriber.events.last[1].with_indifferent_access
-          attributes_match?(event_data["context"])
+          event_context = @error_subscriber.events.last[1].with_indifferent_access["context"]
+          attributes_match?(event_context)
         end
 
         def actual_error
@@ -139,7 +135,7 @@ def actual_error
 
         def attributes_match?(actual)
           @attributes.all? do |key, value|
-            if defined?(RSpec::Matchers) && value.respond_to?(:matches?)
+            if value.respond_to?(:matches?)
               value.matches?(actual[key])
             else
               actual[key] == value
@@ -149,7 +145,7 @@ def attributes_match?(actual)
 
         def unmatched_attributes(actual)
           @attributes.reject do |key, value|
-            if defined?(RSpec::Matchers) && value.respond_to?(:matches?)
+            if value.respond_to?(:matches?)
               value.matches?(actual[key])
             else
               actual[key] == value

spec/rspec/rails/matchers/have_reported_error_spec.rb

@@ -95,6 +95,56 @@ class AnotherTestError < StandardError; end
     end
   end
 
+  describe "failure messages for attribute mismatches" do
+    it "provides detailed failure message when attributes don't match" do
+      test_block = proc do
+        Rails.error.report(StandardError.new("test"), context: { user_id: 123, context: "actual" })
+      end
+      matcher = have_reported_error.with(user_id: 456, context: "expected")
+
+      matcher.matches?(test_block)
+
+      expect(matcher.failure_message).to include("Expected error attributes to match")
+      expect(matcher.failure_message).to include("user_id: 456")
+      expect(matcher.failure_message).to include("context: \"expected\"")
+    end
+
+    it "identifies partial attribute mismatches correctly" do
+      test_block = proc do
+        Rails.error.report(StandardError.new("test"), context: { user_id: 123, status: "active", role: "admin" })
+      end
+      matcher = have_reported_error.with(user_id: 456, status: "active") # user_id wrong, status correct
+
+      matcher.matches?(test_block)
+
+      failure_msg = matcher.failure_message
+      expect(failure_msg).to include("got these mismatches: {user_id: 456}")
+    end
+
+    it "handles RSpec matcher mismatches in failure messages" do
+      test_block = proc do
+        Rails.error.report(StandardError.new("test"), context: { params: { foo: "different" } })
+      end
+      matcher = have_reported_error.with(params: a_hash_including(foo: "bar"))
+
+      matcher.matches?(test_block)
+
+      expect(matcher.failure_message).to include("Expected error attributes to match")
+    end
+
+    it "shows actual context values when attributes don't match" do
+      test_block = proc do
+        Rails.error.report(StandardError.new("test"), context: { user_id: 123, context: "actual" })
+      end
+      matcher = have_reported_error.with(user_id: 456)
+
+      matcher.matches?(test_block)
+
+      failure_msg = matcher.failure_message
+      expect(failure_msg).to include("actual values are {\"user_id\" => 123, \"context\" => \"actual\"}")
+    end
+  end
+
   describe "attribute matching with .with chain" do
     it "passes when attributes match exactly" do
       test_block = proc do