Don't allow to redefine attributes with chaining in with_context method

Author: Stanislav (Stas) Katkov

lib/rspec/rails/matchers/have_reported_error.rb

@@ -34,6 +34,12 @@ def initialize(expected_error_or_message, expected_message)
         end
 
         def with_context(expected_attributes)
+          conflicting_keys = @attributes.keys & expected_attributes.keys
+          unless conflicting_keys.empty?
+            raise ArgumentError, "Attribute keys #{conflicting_keys.inspect} are already defined. " \
+                                "Chaining with_context calls should not overwrite existing attributes. " \
+                                "Use a single with_context call with all attributes instead."
+          end
           @attributes.merge!(expected_attributes)
           self
         end

spec/rspec/rails/matchers/have_reported_error_spec.rb

@@ -163,6 +163,20 @@ class AnotherTestError < StandardError; end
         expect { "no error" }.to have_reported_error.with_context(user_id: 123)
       }.to fail_with(/Expected the block to report an error, but none was reported./)
     end
+
+    describe "chaining with_context calls" do
+      it "accumulates attributes when different keys are used in chained calls" do
+        expect {
+          Rails.error.report(StandardError.new("test"), context: { user_id: 123, session_id: "abc123", role: "admin" })
+        }.to have_reported_error.with_context(user_id: 123).with_context(session_id: "abc123")
+      end
+
+      it "raises error when trying to overwrite existing attribute keys" do
+        expect {
+          have_reported_error.with_context(user_id: 123).with_context(user_id: 456)
+        }.to raise_error(ArgumentError, /Attribute keys \[:user_id\] are already defined/)
+      end
+    end
   end
 
   context "constrained by message only" do