rename .with to .with_context

Author: skatkov

lib/rspec/rails/matchers/have_reported_error.rb

@@ -29,7 +29,7 @@ def initialize(expected_error = nil)
           @error_subscriber = nil
         end
 
-        def with(expected_attributes)
+        def with_context(expected_attributes)
           @attributes.merge!(expected_attributes)
           self
         end
@@ -46,7 +46,7 @@ def matches?(block)
           @error_subscriber = ErrorSubscriber.new
           ::Rails.error.subscribe(@error_subscriber)
 
-          block&.call
+          block.call
 
           return false if @error_subscriber.events.empty? && !@expected_error.nil?
           return false unless error_matches_expectation?
@@ -176,7 +176,7 @@ def unmatched_attributes(actual)
       #   expect { Rails.error.report(MyError.new("message")) }.to have_reported_error(MyError.new("message"))
       #
       # @example Checking error attributes
-      #   expect { Rails.error.report(StandardError.new, context: "test") }.to have_reported_error.with(context: "test")
+      #   expect { Rails.error.report(StandardError.new, context: "test") }.to have_reported_error.with_context(context: "test")
       #
       # @example Checking error message patterns
       #   expect { Rails.error.report(StandardError.new("test message")) }.to have_reported_error(/test/)

spec/rspec/rails/matchers/have_reported_error_spec.rb

@@ -85,69 +85,69 @@ class AnotherTestError < StandardError; end
       expect {
         expect {
           Rails.error.report(StandardError.new("test"), context: { user_id: 123, context: "actual" })
-        }.to have_reported_error.with(user_id: 456, context: "expected")
+        }.to have_reported_error.with_context(user_id: 456, context: "expected")
       }.to fail_with(/Expected error attributes to match {user_id: 456, context: "expected"}, but got these mismatches: {user_id: 456, context: "expected"} and actual values are {"user_id" => 123, "context" => "actual"}/)
     end
 
     it "identifies partial attribute mismatches correctly" do
       expect {
         expect {
           Rails.error.report(StandardError.new("test"), context: { user_id: 123, status: "active", role: "admin" })
-        }.to have_reported_error.with(user_id: 456, status: "active") # user_id wrong, status correct
+        }.to have_reported_error.with_context(user_id: 456, status: "active") # user_id wrong, status correct
       }.to fail_with(/got these mismatches: {user_id: 456}/)
     end
 
     it "handles RSpec matcher mismatches in failure messages" do
       expect {
         expect {
           Rails.error.report(StandardError.new("test"), context: { params: { foo: "different" } })
-        }.to have_reported_error.with(params: a_hash_including(foo: "bar"))
+        }.to have_reported_error.with_context(params: a_hash_including(foo: "bar"))
       }.to fail_with(/Expected error attributes to match/)
     end
 
     it "shows actual context values when attributes don't match" do
       expect {
         expect {
           Rails.error.report(StandardError.new("test"), context: { user_id: 123, context: "actual" })
-        }.to have_reported_error.with(user_id: 456)
+        }.to have_reported_error.with_context(user_id: 456)
       }.to fail_with(/actual values are {"user_id" => 123, "context" => "actual"}/)
     end
   end
 
-  describe "#with" do
+  describe "#with_context" do
     it "passes when attributes match exactly" do
       expect {
         Rails.error.report(StandardError.new("test"), context: { user_id: 123, context: "test" })
-      }.to have_reported_error.with(user_id: 123, context: "test")
+      }.to have_reported_error.with_context(user_id: 123, context: "test")
     end
 
     it "passes with partial attribute matching" do
       expect {
         Rails.error.report(
           StandardError.new("test"), context: { user_id: 123, context: "test", extra: "data" }
         )
-      }.to have_reported_error.with(user_id: 123)
+      }.to have_reported_error.with_context(user_id: 123)
     end
 
     it "passes with hash matching using RSpec matchers" do
       expect {
         Rails.error.report(
           StandardError.new("test"), context: { params: { foo: "bar", baz: "qux" } }
         )
-      }.to have_reported_error.with(params: a_hash_including(foo: "bar"))
+      }.to have_reported_error.with_context(params: a_hash_including(foo: "bar"))
     end
 
     it "fails when attributes do not match" do
       expect {
         expect {
           Rails.error.report(StandardError.new("test"), context: { user_id: 123, context: "actual" })
-        }.to have_reported_error.with(user_id: 456, context: "expected")
+        }.to have_reported_error.with_context(user_id: 456, context: "expected")
       }.to fail_with(/Expected error attributes to match {user_id: 456, context: "expected"}, but got these mismatches: {user_id: 456, context: "expected"} and actual values are {"user_id" => 123, "context" => "actual"}/)
     end
 
     it "fails when no error is reported but attributes are expected" do
       expect {
-        expect { "no error" }.to have_reported_error.with(user_id: 123)
+        expect { "no error" }.to have_reported_error.with_context(user_id: 123)
       }.to fail_with(/Expected the block to report an error, but none was reported./)
     end
   end