should require a block matcher

Author: skatkov

lib/rspec/rails/matchers/have_reported_error.rb

@@ -33,6 +33,10 @@ def with(expected_attributes)
         end
 
         def matches?(block)
+          if block.nil?
+            raise ArgumentError, "block is required for have_reported_error matcher"
+          end
+
           @error_subscriber = ErrorSubscriber.new
           ::Rails.error.subscribe(@error_subscriber)
 
@@ -181,6 +185,8 @@ def unmatched_attributes(actual)
       def have_reported_error(expected_error = nil)
         HaveReportedError.new(expected_error)
       end
+
+      alias_method :reports_error, :have_reported_error
     end
   end
 end

spec/rspec/rails/matchers/have_reported_error_spec.rb

@@ -4,6 +4,16 @@
   class TestError < StandardError; end
   class AnotherTestError < StandardError; end
 
+  it "has an reports_error alias" do
+    expect {Rails.error.report(StandardError.new("test error"))}.to reports_error
+  end
+
+  it "warns that passing value expectation doesn't work" do
+    expect {
+      expect(Rails.error.report(StandardError.new("test error"))).to have_reported_error
+    }.to raise_error(ArgumentError, "block is required for have_reported_error matcher")
+  end
+
   describe "basic functionality" do
     it "passes when an error is reported" do
       expect {Rails.error.report(StandardError.new("test error"))}.to have_reported_error