win: add --return-nonzero-on-failures to sc_testpilot

xavierd · facebook-github-bot · commit b4966a7dbc08 · 2021-07-01T09:14:28.000-07:00
Summary:
For whatever reason, sc_testpilot default to --return-zero-on-failures, which
means that test failures are simply not reported properly to the signal box.
Fix that by explicitely passing --return-nonzero-on-failures

Reviewed By: fanzeyi

Differential Revision: D29509158

fbshipit-source-id: ef991f91df48e99769f96ffd8d7015cdf507c723
diff --git a/build/fbcode_builder/getdeps/builder.py b/build/fbcode_builder/getdeps/builder.py
@@ -741,6 +741,7 @@ def list_tests():
                     "--test-config",
                     "platform=%s" % machine_suffix,
                     "buildsystem=getdeps",
+                    "--return-nonzero-on-failures",
                 ]
             else:
                 testpilot_args = [

Original file line number	Diff line number	Diff line change
`@@ -741,6 +741,7 @@ def list_tests():`
`741`	`741`	`"--test-config",`
`742`	`742`	`"platform=%s" % machine_suffix,`
`743`	`743`	`"buildsystem=getdeps",`
	`744`	`+ "--return-nonzero-on-failures",`
`744`	`745`	`]`
`745`	`746`	`else:`
`746`	`747`	`testpilot_args = [`