[v638][ntuple] fix streamer info creation #20415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the templated version of the RClassField, the type name passed to TClass::GetClass() must not use the RNTuple normalized name but the demangled name or the meta normalized name. Otherwise, RNTuple may normalize, e.g., `long long` to `std::int64_t`, which in turn gets normalized by Meta to `unsigned long`. (cherry picked from commit 4a789b0)
(cherry picked from commit 2d27aed)
Get the streamer info records of class fields and streamer fields from their meta (TClass) normalized name. Previously, the names came from the descriptor, which has them already RNTuple normalized. (cherry picked from commit 1f6a481)
Test Results 22 files 22 suites 3d 19h 2m 43s ⏱️ For more details on these failures, see this check. Results for commit 1657cd5. |
jblomer
merged commit aac7d06
into
root-project:v6-38-00-patches
29 of 31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20282