Skip to content

Conversation

@guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Nov 13, 2025

This is done now because it prevents various distracting linter warnings in ROOT/__init__.py in the "Files changed" section in the PR view when this file is changed.

@guitargeek guitargeek self-assigned this Nov 13, 2025
@guitargeek guitargeek changed the title [Python] Local imports in _facade.py to delay pythonization lib. loading [Python] Make the linter happy about ROOT/__init__.py Nov 13, 2025
This should fix errors on Windows where the `libROOTPythonizations` is
attempted to be loaded before the DLL directory is set correctly in
`ROOT/__init__.py`.
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Test Results

    22 files      22 suites   4d 1h 11m 49s ⏱️
 3 776 tests  3 776 ✅ 0 💤 0 ❌
81 133 runs  81 133 ✅ 0 💤 0 ❌

Results for commit 4ed483b.

♻️ This comment has been updated with latest results.

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have a question, just a curiosity.

@guitargeek guitargeek merged commit c7103f3 into root-project:master Nov 14, 2025
52 of 53 checks passed
@guitargeek guitargeek deleted the fixup branch November 14, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants