From d3d8f5f8b374b95fb72c88ee13d4525b9148234b Mon Sep 17 00:00:00 2001 From: Jonas Hahnfeld Date: Wed, 12 Nov 2025 11:45:41 +0100 Subject: [PATCH] [hist] Remove mentions of SetBinContent We decided to not add this method to the public interface because it has unclear semantics for a number of cases, in particular related to global histogram statistics. While it might be fine to allow it in RHistEngine, it would also be confusing to then not have it in RHist. --- hist/histv7/doc/CodeArchitecture.md | 2 +- hist/histv7/doc/DesignImplementation.md | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hist/histv7/doc/CodeArchitecture.md b/hist/histv7/doc/CodeArchitecture.md index 1c21078d4760b..94b2d6fb10bf3 100644 --- a/hist/histv7/doc/CodeArchitecture.md +++ b/hist/histv7/doc/CodeArchitecture.md @@ -68,7 +68,7 @@ Objects of this type are passed by value. A single bin index, which is just an integer for normal bins. `Underflow()` and `Overflow()` are special values and not ordered with respect to others. -Objects of this type are passed by value; most notably to `GetBinContent` and `SetBinContent`. +Objects of this type are passed by value; most notably to `GetBinContent`. ### `RBinIndexRange` diff --git a/hist/histv7/doc/DesignImplementation.md b/hist/histv7/doc/DesignImplementation.md index f0e3407efb58d..e58b776d89ac2 100644 --- a/hist/histv7/doc/DesignImplementation.md +++ b/hist/histv7/doc/DesignImplementation.md @@ -55,10 +55,9 @@ This will copy the arguments, which is fine in this case because `RBinIndex` is ### Special Arguments Special arguments are passed last. -Examples include +For example ```cpp template void Fill(const std::tuple &args, RWeight w); -template void SetBinContent(const std::array &indices, const BinContentType &content); ``` The same works for the variadic function templates that will check the type of the last argument.