Skip to content

[RF] additional RooNaNPacker tests #20346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[RF] additional RooNaNPacker tests #20346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec27741
[RF] additional RooNaNPacker tests
egpbos Jun 14, 2024
7574579
[RF] Remove compiler specific NaNPacker tests
guitargeek Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions roofit/roofitcore/test/testNaNPacker.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,6 @@ TEST(RooNaNPacker, CanPackStuffIntoNaNs)
dumpFloats(rnp._payload);
}

#if !defined(_MSC_VER) || defined(_WIN64) || defined(NDEBUG) || defined(R__ENABLE_BROKEN_WIN_TESTS)

// Demonstrate value preserving behavior after arithmetic on packed NaNs.
TEST(RooNaNPacker, PackedNaNPreservedAfterArithmetic)
{
Expand Down Expand Up @@ -138,9 +136,39 @@ TEST(RooNaNPacker, PackedNaNPreservedAfterArithmetic)
EXPECT_TRUE(rnp2.isNaNWithPayload());
// nothing can harm the PackedNaN
EXPECT_EQ(rnp.getPayload(), rnp2.getPayload());
}

#endif // !defined(_MSC_VER) || defined(R__ENABLE_BROKEN_WIN_TESTS)
// multiply packed NaN by 0
rnp2._payload = 0. * rnp.getNaNWithPayload();
EXPECT_TRUE(rnp2.isNaNWithPayload());
// PackedNaN pays no mind
EXPECT_EQ(rnp.getPayload(), rnp2.getPayload());

// add packed NaN to regular NaN
rnp2._payload = std::numeric_limits<double>::quiet_NaN() + rnp.getNaNWithPayload();
// first NaN wins, though! now the payload is gone
EXPECT_FALSE(rnp2.isNaNWithPayload());
// a quiet NaN has a "payload" of zero
EXPECT_EQ(0, rnp2.getPayload());

// ... other way around
rnp2._payload = rnp.getNaNWithPayload() + std::numeric_limits<double>::quiet_NaN();
EXPECT_TRUE(rnp2.isNaNWithPayload());
// if it comes first, the PackedNaN does survive
EXPECT_EQ(rnp.getPayload(), rnp2.getPayload());

// multiply regular NaN with packed NaN
rnp2._payload = rnp.getNaNWithPayload() * std::numeric_limits<double>::quiet_NaN();
EXPECT_TRUE(rnp2.isNaNWithPayload());
// if it comes first, the PackedNaN does survive
EXPECT_EQ(rnp.getPayload(), rnp2.getPayload());

// ... other way around
rnp2._payload = std::numeric_limits<double>::quiet_NaN() * rnp.getNaNWithPayload();
// same as with addition: the first NaN wins
EXPECT_FALSE(rnp2.isNaNWithPayload());
// a quiet NaN has a "payload" of zero
EXPECT_EQ(0, rnp2.getPayload());
}

/// Fit a simple linear function, that starts in the negative.
TEST(RooNaNPacker, FitSimpleLinear)
Expand Down
Loading