[hist] Remove casts in TH[23]L::AddBinContent

hahnjo · hahnjo · commit 6ce64eda2ea6 · 2025-11-08T10:36:54.000+01:00
They would truncate the count to 32 bits.
diff --git a/hist/hist/src/TH2.cxx b/hist/hist/src/TH2.cxx
@@ -3684,7 +3684,7 @@ void TH2L::AddBinContent(Int_t bin)
 void TH2L::AddBinContent(Int_t bin, Double_t w)
 {
    Long64_t newval = fArray[bin] + Long64_t(w);
-   if (newval > -LLONG_MAX && newval < LLONG_MAX) {fArray[bin] = Int_t(newval); return;}
+   if (newval > -LLONG_MAX && newval < LLONG_MAX) {fArray[bin] = newval; return;}
    if (newval < -LLONG_MAX) fArray[bin] = -LLONG_MAX;
    if (newval >  LLONG_MAX) fArray[bin] =  LLONG_MAX;
 }
diff --git a/hist/hist/src/TH3.cxx b/hist/hist/src/TH3.cxx
@@ -4344,7 +4344,7 @@ void TH3L::AddBinContent(Int_t bin)
 void TH3L::AddBinContent(Int_t bin, Double_t w)
 {
    Long64_t newval = fArray[bin] + Long64_t(w);
-   if (newval > -LLONG_MAX && newval < LLONG_MAX) {fArray[bin] = Int_t(newval); return;}
+   if (newval > -LLONG_MAX && newval < LLONG_MAX) {fArray[bin] = newval; return;}
    if (newval < -LLONG_MAX) fArray[bin] = -LLONG_MAX;
    if (newval >  LLONG_MAX) fArray[bin] =  LLONG_MAX;
 }

Original file line number	Diff line number	Diff line change
`@@ -3684,7 +3684,7 @@ void TH2L::AddBinContent(Int_t bin)`
`3684`	`3684`	`void TH2L::AddBinContent(Int_t bin, Double_t w)`
`3685`	`3685`	`{`
`3686`	`3686`	`Long64_t newval = fArray[bin] + Long64_t(w);`
`3687`		`- if (newval > -LLONG_MAX && newval < LLONG_MAX) {fArray[bin] = Int_t(newval); return;}`
	`3687`	`+ if (newval > -LLONG_MAX && newval < LLONG_MAX) {fArray[bin] = newval; return;}`
`3688`	`3688`	`if (newval < -LLONG_MAX) fArray[bin] = -LLONG_MAX;`
`3689`	`3689`	`if (newval > LLONG_MAX) fArray[bin] = LLONG_MAX;`
`3690`	`3690`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4344,7 +4344,7 @@ void TH3L::AddBinContent(Int_t bin)`
`4344`	`4344`	`void TH3L::AddBinContent(Int_t bin, Double_t w)`
`4345`	`4345`	`{`
`4346`	`4346`	`Long64_t newval = fArray[bin] + Long64_t(w);`
`4347`		`- if (newval > -LLONG_MAX && newval < LLONG_MAX) {fArray[bin] = Int_t(newval); return;}`
	`4347`	`+ if (newval > -LLONG_MAX && newval < LLONG_MAX) {fArray[bin] = newval; return;}`
`4348`	`4348`	`if (newval < -LLONG_MAX) fArray[bin] = -LLONG_MAX;`
`4349`	`4349`	`if (newval > LLONG_MAX) fArray[bin] = LLONG_MAX;`
`4350`	`4350`	`}`