Clean code #143
Open
Clean code #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o HTML5 document type
…concise and update tag selectors
…tifiers and classes concise, tag selectors, indentation in blocks, space after property name, semicolon after properties, separate selectors and properties
…ut semicolon, use double quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://github.com/rolling-scopes-school/js-fe-course-en/blob/main/modules/clean-code/clean-code.md
Screenshot:
Deploy: https://github.com/nataliafomdev/clean-code-s1e1/pull/1
Done 14.02.2025 / deadline 16.02.2025
Score: 45 / 45
Beginner level
General HTML & CSS rules
1.1. Indentation
1.2. Use lowercase
1.3. Quotes in HTML & CSS files
HTML
2.1. Formatting
2.2. Document Type
2.3. Named character references
2.4. 'type' attribute
2.5. HTML Line-Wrapping
CSS
3.1. Single style for selectors naming
3.2. Meaningful naming of identifiers and classes:
3.3. Keep the names of identifiers and classes concise
3.4. Tag selectors
3.5. Indentation in blocks
3.6. Space after property name
3.7. Semicolon after properties
3.8. Separate selectors and propertiesed. There should be one HTML-file, JS-file, and one CSS-file (or it can be embedded right in the HTML-file). (20/20)
Advanced level
HTML
1.1. Semantics
1.2. Media alternatives
CSS
2.1. BEM