Extract canSendReplay into its own private ReplayManager static function (#1343)

Author: matux

src/browser/replay/replayManager.js

@@ -248,6 +248,31 @@ export default class ReplayManager {
     return replayId;
   }
 
+  /**
+   * Determines if a replay can be sent based on API response and headers.
+   *
+   * @param {Error|null} err - Any error that occurred during the API request
+   * @param {Object|null} resp - The API response object
+   * @param {Object|null} hs - The response headers
+   * @returns {boolean} true if the replay can be sent, false otherwise.
+   * @private
+   */
+  static _canSendReplay(err, resp, hs) {
+    if (!hs) return false;
+
+    const hasNoErrors = !err && resp?.err === 0;
+
+    const headers = Object.fromEntries(
+      Object.entries(hs).map(([k, v]) => [k.toLowerCase(), String(v).trim()]),
+    );
+
+    const headersAreValid =
+      headers['rollbar-replay-enabled'] === 'true' &&
+      headers['rollbar-replay-ratelimit-remaining'] !== '0';
+
+    return hasNoErrors && headersAreValid;
+  }
+
   /**
    * Sends or discards a replay based on whether it can be sent.
    *
@@ -260,13 +285,13 @@ export default class ReplayManager {
    * Called by Queue after determining replay eligibility from API response.
    *
    * @param {string} replayId - The ID of the replay to send or discard
+   * @param {Error|null} err - Any error that occurred during the API request
+   * @param {Object|null} resp - The API response object
+   * @param {Object|null} headers - The response headers
+   * @returns {Promise<void>} A promise that resolves when the operation is complete
    */
   async sendOrDiscardReplay(replayId, err, resp, headers) {
-    const canSendReplay =
-      !err &&
-      resp?.err === 0 &&
-      headers?.['Rollbar-Replay-Enabled'] === 'true' &&
-      headers?.['Rollbar-Replay-RateLimit-Remaining'] !== '0';
+    const canSendReplay = ReplayManager._canSendReplay(err, resp, headers);
 
     if (canSendReplay) {
       try {

test/replay/unit/replayManager.test.js

@@ -429,6 +429,80 @@ describe('ReplayManager', function () {
     });
   });
 
+  describe('_canSendReplay', function () {
+    it('returns true when all conditions are met', function () {
+      const result = ReplayManager._canSendReplay(
+        null,
+        { err: 0 },
+        {
+          'Rollbar-Replay-Enabled': 'true',
+          'Rollbar-Replay-RateLimit-Remaining': '10',
+        },
+      );
+      expect(result).to.be.true;
+    });
+
+    it('returns false when err is truthy', function () {
+      const result = ReplayManager._canSendReplay(
+        new Error('API error'),
+        { err: 0 },
+        { 'Rollbar-Replay-Enabled': 'true' },
+      );
+      expect(result).to.be.false;
+    });
+
+    it('returns false when resp.err is non-zero', function () {
+      const result = ReplayManager._canSendReplay(null, { err: 1 }, {
+        'Rollbar-Replay-Enabled': 'true',
+      });
+      expect(result).to.be.false;
+    });
+
+    it('returns false when resp is null', function () {
+      const result = ReplayManager._canSendReplay(null, null, {
+        'Rollbar-Replay-Enabled': 'true',
+      });
+      expect(result).to.be.false;
+    });
+
+    it('returns false when Rollbar-Replay-Enabled is not "true"', function () {
+      const result = ReplayManager._canSendReplay(null, { err: 0 }, {
+        'Rollbar-Replay-Enabled': 'false',
+        'Rollbar-Replay-RateLimit-Remaining': '10',
+      });
+      expect(result).to.be.false;
+    });
+
+    it('returns false when Rollbar-Replay-RateLimit-Remaining is "0"', function () {
+      const result = ReplayManager._canSendReplay(null, { err: 0 }, {
+        'Rollbar-Replay-Enabled': 'true',
+        'Rollbar-Replay-RateLimit-Remaining': '0',
+      });
+      expect(result).to.be.false;
+    });
+
+    it('returns false when headers are null', function () {
+      const result = ReplayManager._canSendReplay(null, { err: 0 }, null);
+      expect(result).to.be.false;
+    });
+
+    it('handles case-insensitive headers', function () {
+      const result = ReplayManager._canSendReplay(null, { err: 0 }, {
+        'rollbar-replay-enabled': 'true',
+        'ROLLBAR-REPLAY-RATELIMIT-REMAINING': '10',
+      });
+      expect(result).to.be.true;
+    });
+
+    it('handles whitespace in header values', function () {
+      const result = ReplayManager._canSendReplay(null, { err: 0 }, {
+        'Rollbar-Replay-Enabled': ' true ',
+        'Rollbar-Replay-RateLimit-Remaining': ' 10 ',
+      });
+      expect(result).to.be.true;
+    });
+  });
+
   describe('sendOrDiscardReplay', function () {
     beforeEach(function () {
       replayManager.setSpans('test-replay', [{ id: 'span1' }]);