Skip to content

Commit e0b9641

Browse files
Rodrigo Dos SantosRodrigo Dos Santos
authored andcommitted
Fixed AWS ECS Configuration - build person-service
1 parent 54ddc43 commit e0b9641

File tree

4 files changed

+20
-6
lines changed

4 files changed

+20
-6
lines changed

.github/.aws/authentication-service-task-definition.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
},
3131
{
3232
"name": "SPRING_DATA_MONGODB_URI",
33-
"value": "${{ env.SPRING_DATA_MONGODB_URI }}"
33+
"value": "#SPRING_DATA_MONGODB_URI"
3434
},
3535
{
3636
"name": "OPENTRACING_JAEGER_ENABLED",
@@ -42,7 +42,7 @@
4242
},
4343
{
4444
"name": "COM_MICROSERVICE_AUTHENTICATION_JWT_KEY_VALUE",
45-
"value": "${{ env.COM_MICROSERVICE_AUTHENTICATION_JWT_KEY_VALUE }}"
45+
"value": "#COM_MICROSERVICE_AUTHENTICATION_JWT_KEY_VALUE"
4646
},
4747
{
4848
"name": "SPRING_PROFILES_ACTIVE",

.github/.aws/person-service-task-definition.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
},
3131
{
3232
"name": "SPRING_DATA_MONGODB_URI",
33-
"value": "$SPRING_DATA_MONGODB_URI"
33+
"value": "#SPRING_DATA_MONGODB_URI"
3434
},
3535
{
3636
"name": "OPENTRACING_JAEGER_ENABLED",
@@ -42,7 +42,7 @@
4242
},
4343
{
4444
"name": "COM_MICROSERVICE_AUTHENTICATION_JWT_KEY_VALUE",
45-
"value": "${{ env.COM_MICROSERVICE_AUTHENTICATION_JWT_KEY_VALUE }}"
45+
"value": "#COM_MICROSERVICE_AUTHENTICATION_JWT_KEY_VALUE"
4646
},
4747
{
4848
"name": "SPRING_PROFILES_ACTIVE",

.github/workflows/docker-build-push-image-authentication-service.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ env:
1919
IMAGE: authentication-service
2020
AWS_REGION: ${{ secrets.AWS_REGION }}
2121
ECR_REPOSITORY: ${{ secrets.ECR_REPOSITORY }}
22-
ECS_SERVICE: ${{ secrets.ECS_SERVICE }}
22+
ECS_SERVICE: "authentication-service"
2323
ECS_CLUSTER: ${{ secrets.ECS_CLUSTER }}
2424
ECS_TASK_DEFINITION: ".github/.aws/authentication-service-task-definition.json"
2525
CONTAINER_NAME: ${{ secrets.CONTAINER_NAME }}
@@ -97,6 +97,13 @@ jobs:
9797
${{ secrets.ECR_REPOSITORY }}/authentication-service:latest
9898
${{ secrets.ECR_REPOSITORY }}/authentication-service:${{ env.GITHUB_SHA }}
9999
100+
- uses: microsoft/variable-substitution@v1
101+
with:
102+
files: ".github/.aws/*.json"
103+
env:
104+
"#SPRING_DATA_MONGODB_URI": ${{ env.SPRING_DATA_MONGODB_URI }}
105+
"#COM_MICROSERVICE_AUTHENTICATION_JWT_KEY_VALUE": ${{ env.COM_MICROSERVICE_AUTHENTICATION_JWT_KEY_VALUE }}
106+
100107
- name: Fill in the new image ID in the Amazon ECS task definition
101108
id: task-def
102109
uses: aws-actions/amazon-ecs-render-task-definition@v1

.github/workflows/docker-build-push-image-person-service.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ env:
1919
IMAGE: person-service
2020
AWS_REGION: ${{ secrets.AWS_REGION }}
2121
ECR_REPOSITORY: ${{ secrets.ECR_REPOSITORY }}
22-
ECS_SERVICE: ${{ secrets.ECS_SERVICE }}
22+
ECS_SERVICE: "person-service"
2323
ECS_CLUSTER: ${{ secrets.ECS_CLUSTER }}
2424
ECS_TASK_DEFINITION: ".github/.aws/person-service-task-definition.json"
2525
CONTAINER_NAME: "person-service"
@@ -90,6 +90,13 @@ jobs:
9090
${{ secrets.ECR_REPOSITORY }}/person-service:latest
9191
${{ secrets.ECR_REPOSITORY }}/person-service:${{ env.GITHUB_SHA }}
9292
93+
- uses: microsoft/variable-substitution@v1
94+
with:
95+
files: ".github/.aws/*.json"
96+
env:
97+
"#SPRING_DATA_MONGODB_URI": ${{ env.SPRING_DATA_MONGODB_URI }}
98+
"#COM_MICROSERVICE_AUTHENTICATION_JWT_KEY_VALUE": ${{ env.COM_MICROSERVICE_AUTHENTICATION_JWT_KEY_VALUE }}
99+
93100
- name: Fill in the new image ID in the Amazon ECS task definition
94101
id: task-def
95102
uses: aws-actions/amazon-ecs-render-task-definition@v1

0 commit comments

Comments
 (0)