Skip to content

Commit 8048a5e

Browse files
committed
missing process import, try harder to clean up
1 parent affe7e5 commit 8048a5e

File tree

6 files changed

+18
-15
lines changed

6 files changed

+18
-15
lines changed

atest/acceptance/01_server/00_basic.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
*** Settings ***
2-
Test Teardown Terminate All Processes
2+
Suite Teardown Terminate All Jupyter Servers
33
Library JupyterLibrary
44
Library Process
55
Library OperatingSystem
Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
*** Settings ***
2-
Suite Setup Wait for New Jupyter Server to be Ready
3-
Test Teardown Close All Browsers
2+
Suite Teardown Close All Browsers
3+
Test Teardown Reset JupyterLab and Close
44
Library JupyterLibrary
55
Library Process
66

@@ -13,8 +13,3 @@ Get Help
1313
Open With JupyterLab Menu Help About JupyterLab
1414
Capture Element Screenshot css:.jp-Dialog-content ${OUTPUT_DIR}${/}about.png
1515
Click Element css:${JLAB CSS ACCEPT}
16-
17-
*** Keywords ***
18-
Clean Up Everything
19-
Close All Browsers
20-
Terminate All Processes

atest/acceptance/10_lab/10_notebook.robot

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
*** Settings ***
2-
Suite Setup Wait for New Jupyter Server to be Ready
2+
Suite Teardown Close All Browsers
33
Test Teardown Reset JupyterLab and Close
44
Default Tags notebook
55
Library JupyterLibrary
@@ -20,8 +20,3 @@ IPython Notebook Outputs
2020
\ Add and Run Cell print("${i} hello world " * ${i ** 2})
2121
Wait Until Kernel Is Idle
2222
Screenshot Each Output of Active Document ${OUTPUT_DIR}${/}ipython_outputs/
23-
24-
*** Keywords ***
25-
Clean Up Everything
26-
Close All Browsers
27-
Terminate All Processes
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
*** Settings ***
2+
Suite Setup Wait for New Jupyter Server to be Ready
3+
Suite Teardown Terminate All Jupyter Servers
4+
Library JupyterLibrary

atest/acceptance/__init__.robot

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
11
*** Settings ***
2-
Suite Teardown Terminate All Processes
2+
Suite Teardown Clean Up Everything
3+
Test Timeout 5m
4+
Library JupyterLibrary
35
Library Process
6+
7+
*** Keywords ***
8+
Clean Up Everything
9+
Close All Browsers
10+
Terminate All Jupyter Servers
11+
Terminate All Processes

src/JupyterLibrary/keywords/server.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ def start_new_jupyter_server(
4343
base_url = base_url or "/@rf/"
4444
token = str(uuid4()) if token is None else token
4545

46+
BuiltIn().import_library("Process")
4647
plib = BuiltIn().get_library_instance("Process")
4748

4849
tmpdir = tempfile.mkdtemp()

0 commit comments

Comments
 (0)