Skip to content

Commit 2103fa9

Browse files
committed
go ahead and wait for servers to be running
1 parent bc57890 commit 2103fa9

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

atest/acceptance/01_server/00_basic.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Start three servers
2727
${log2} = Get Process Result ${nb2} stderr=${True}
2828
Should Contain ${log2} The Jupyter Notebook is running msg=Log should contain expected status message
2929
${log3} = Get Process Result ${nb3} stderr=${True}
30-
Should Not Contain ${log3} The Jupyter Notebook is running msg=Unawaited server log should not contain expected status message
30+
Should Contain ${log2} The Jupyter Notebook is running msg=Log should contain expected status message
3131
${terminated} = Terminate All Jupyter Servers
3232
Should be equal as integers ${terminated} 0 msg=No servers should have been terminated
3333

src/JupyterLibrary/keywords/server.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ def start_new_jupyter_server(
6060
args = args or self.build_jupyter_server_arguments(port, base_url, token)
6161

6262
handle = plib.start_process(command, *args, **config)
63+
BuiltIn().sleep("5s")
64+
plib.process_should_be_running(handle)
6365

6466
self._handles += [handle]
6567
self._tmpdirs[handle] = tmpdir

0 commit comments

Comments
 (0)