Skip to content

Fix/22 exceptiongroupexceptiongroup unhandled errors in a taskgroup 1 sub exception #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix/22 exceptiongroupexceptiongroup unhandled errors in a taskgroup 1 sub exception #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26fd61d
Fixed Python version to >= 3.11 to fix compatibility imports for Exce…
stex2005 Nov 4, 2025
bb1468a
ruff format
stex2005 Nov 4, 2025
cfa3841
Updated setup.sh for Python 3.11
stex2005 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions clients/gemini_live/gemini_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,13 +343,20 @@ async def run(self):
await send_text_task
raise asyncio.CancelledError("User requested exit")

except asyncio.CancelledError:
# Normal exit when user types 'q'
print("\nGoodbye!")
pass
except asyncio.ExceptionGroup as exception_group:
except* Exception as exception_group:
# Handle any errors that occurred in the task group
traceback.print_exception(exception_group)
# Check if it's a CancelledError (normal exit)
if any(
isinstance(exc, asyncio.CancelledError)
for exc in exception_group.exceptions
):
print("\nGoodbye!")
else:
traceback.print_exception(
type(exception_group),
exception_group,
exception_group.__traceback__,
)


def main():
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "robot-mcp-client"
version = "0.1.0"
description = "Connect AI Language Models with Robots on ROS using MCP"
readme = "README.md"
requires-python = ">=3.10"
requires-python = ">=3.11"
authors = [
{ name = "Stefano Dalla Gasperina"},
{ name = "Rohit John Varghese"},
Expand Down
8 changes: 4 additions & 4 deletions setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ esac

echo "Detected OS: $PLATFORM"

# Ensure Python 3.10+
# Ensure Python 3.11+ (Note: uv will auto-download the correct version if needed)
ensure_python() {
case "$PLATFORM" in
mac)
Expand All @@ -25,7 +25,7 @@ ensure_python() {
echo "Installing Python via Homebrew..."
brew install python@3.11 || brew install python@3.12
else
echo "Install Python 3.10+ from https://www.python.org/downloads/"
echo "Install Python 3.11+ from https://www.python.org/downloads/"
fi
fi
;;
Expand All @@ -39,13 +39,13 @@ ensure_python() {
elif command -v pacman >/dev/null 2>&1; then
sudo pacman -S --noconfirm python python-virtualenv
else
echo "Install Python 3.10+ using your package manager"
echo "Install Python 3.11+ using your package manager"
fi
fi
;;
windows)
if ! command -v python >/dev/null 2>&1 && ! command -v python3 >/dev/null 2>&1; then
echo "Install Python 3.10+ from https://www.python.org/downloads/ and add to PATH"
echo "Install Python 3.11+ from https://www.python.org/downloads/ and add to PATH"
fi
;;
esac
Expand Down