add tests for hover and goto for variable imports

Author: d-biehl

.vscode/launch.json

@@ -195,6 +195,17 @@
 				"${workspaceFolder}/out/test/**/*.js"
 			],
 			"preLaunchTask": "npm: compile"
+		},
+		{
+			"name": "Python: Debug Tests",
+			"type": "python",
+			"request": "launch",
+			"program": "${file}",
+			"purpose": [
+				"debug-test"
+			],
+			"console": "integratedTerminal",
+			"justMyCode": false
 		}
 	],
 	"inputs": [

robotcode/language_server/robotframework/diagnostics/library_doc.py

@@ -1221,6 +1221,7 @@ def get_variables_doc(
     from robot.variables.filesetter import PythonImporter, YamlImporter
 
     source: Optional[str] = None
+    stem = Path(name).stem
     try:
         source = find_file(name, working_dir, base_dir, pythonpath, environment, variables)
 
@@ -1234,13 +1235,13 @@ def get_variables_doc(
         ]
 
         return VariablesDoc(
-            name,
+            name=stem,
             source=source,
             variables=vars,
         )
     except BaseException as e:
         return VariablesDoc(
-            name=name,
+            name=stem,
             source=source,
             errors=[
                 error_from_exception(

robotcode/language_server/robotframework/parts/hover.py

@@ -318,7 +318,7 @@ async def hover_VariablesImport(  # noqa: N802
 
                 try:
                     libdoc = await namespace.get_imported_variables_libdoc(variables_node.name, variables_node.args)
-                    
+
                     if libdoc is None or libdoc.errors:
                         libdoc = await namespace.imports_manager.get_libdoc_for_variables_import(
                             str(variables_node.name), (), str(document.uri.to_path().parent)

tests/robotcode/language_server/robotframework/parts/data/goto.robot

@@ -5,7 +5,7 @@ Library           Collections
 Library           ${CURDIR}/libs/myvariables.py
 #                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  Library Import by Path: len(result) == 1 and result[0].target_uri.endswith("/libs/myvariables.py")
 Variables         ${CURDIR}/libs/myvariables.py
-# TODO                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  Variables Import: len(result) == 1 and result[0].target_uri.endswith("libs/myvariables.py")
+#                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  Variables Import: len(result) == 1 and result[0].target_uri.endswith("libs/myvariables.py")
 Resource          ${CURDIR}/resources/firstresource.resource
 #                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  Resource Import: len(result) == 1 and result[0].target_uri.endswith("/resources/firstresource.resource")
 
@@ -26,9 +26,5 @@ first
 #              ^^^^^^  For Variable: len(result) == 1 and result[0].target_uri.endswith("/data/goto.robot")
 #                     ^^^^^^^^  For Variable: len(result) == 1 and result[0].target_uri.endswith("/data/goto.robot")
     END
-    Log    ${CMD_VAR}
-# TODO         ^^^^^^^^^^  Command Line Variable: len(result) == 1 and result[0].target_uri.endswith("...")
-    Log    ${CURDIR}
-# TODO     ^^^^^^^^^  BuiltIn Variable: len(result) == 1 and result[0].target_uri.endswith("...")
     Log    ${A_VAR_FROM_LIB}
-# TODO     ^^^^^^^^^^^^^^^^^  Imported Variable: len(result) == 1 and result[0].target_uri.endswith("...")
+#          ^^^^^^^^^^^^^^^^^  Imported Variable: len(result) == 1 and result[0].target_uri.endswith("libs/myvariables.py")

tests/robotcode/language_server/robotframework/parts/data/hover.robot

@@ -6,8 +6,9 @@ Library           ${CURDIR}/libs/myvariables.py
 # TODO            ^^^^^^^^^  variable in library import: value == '(builtin variable) ${CURDIR}'
 Variables         ${CURDIR}/libs/myvariables.py
 # TODO            ^^^^^^^^^  variable in variables import: value == '(builtin variable) ${CURDIR}'
+#                                ^^^^^^^^^^^^^^ variable import by path name: re.match(r'## Variables \*myvariables.*', value)
 Resource          ${CURDIR}/resources/firstresource.resource
-#                                     ^^^^^^^^^^^^^^ library import by path name: re.match(r'## Resource \*firstresource.*', value)
+#                                     ^^^^^^^^^^^^^^ resource import by path name: re.match(r'## Resource \*firstresource.*', value)
 # TODO            ^^^^^^^^^  variable in resource import: value == '(builtin variable) ${CURDIR}'
 
 *** Variables ***
@@ -34,7 +35,7 @@ first
 #          ^^^^^^^^^    BuiltIn variable: value == '(builtin variable) ${CURDIR}'
 #^^^    Spaces: result is None
     Log    ${A_VAR_FROM_LIB}
-# TODO         ^^^^^^^^^^^^^^^^^    variable from lib: value == '(imported variable) ${A_VAR_FROM_LIB}'
+#          ^^^^^^^^^^^^^^^^^    variable from lib: value == '(imported variable) ${A_VAR_FROM_LIB}'
 
 
 *** Keywords ***

tests/robotcode/language_server/robotframework/tools.py

@@ -54,7 +54,7 @@ def generate_tests_from_source_document(
 
 def generate_test_id(params: Any) -> Any:
     if isinstance(params, GeneratedTestData):
-        return f"{params.line}-{params.character}-{params.name}"
+        return f"{params.line:03}-{params.character:03}-{params.name}"
     if dataclasses.is_dataclass(params):
         return repr(params)
     if isinstance(params, Path):