find unused loop and except variables

Author: d-biehl

robotcode/language_server/robotframework/diagnostics/analyzer.py

@@ -149,6 +149,7 @@ async def visit(self, node: ast.AST) -> None:
             KeywordCall,
             Template,
             TestTemplate,
+            Variable,
         )
         from robot.variables.search import contains_variable
 
@@ -167,7 +168,9 @@ async def visit(self, node: ast.AST) -> None:
                 for token1 in (
                     t
                     for t in node.tokens
-                    if t.type != RobotToken.VARIABLE and t.error is None and contains_variable(t.value, "$@&%")
+                    if not (isinstance(node, Variable) and t.type == RobotToken.VARIABLE)
+                    and t.error is None
+                    and contains_variable(t.value, "$@&%")
                 ):
                     async for token in self.yield_argument_name_and_rest(node, token1):
                         if isinstance(node, Arguments) and token.value == "@{}":
@@ -199,6 +202,7 @@ async def visit(self, node: ast.AST) -> None:
                                     elif var not in self._variable_references and token1.type in [
                                         RobotToken.ASSIGN,
                                         RobotToken.ARGUMENT,
+                                        RobotToken.VARIABLE,
                                     ]:
                                         self._variable_references[var] = set()