move mypy settings to pyproject.toml

Author: d-biehl

mypy.ini

@@ -124,3 +124,15 @@ exclude_lines = [
   "raise NotImplementedError",
 ]
 fail_under = 40
+
+[tool.mypy]
+# MyPy config
+# File reference here - http://mypy.readthedocs.io/en/latest/config_file.html#config-file
+python_version = 3.8
+warn_redundant_casts = true
+warn_unused_ignores = true
+warn_return_any = true
+warn_unused_configs = true
+strict = true
+disallow_subclassing_any = false
+ignore_missing_imports = true

pyproject.toml

@@ -4,7 +4,7 @@
 from robot.running import TestCase, TestSuite
 
 
-class ByLongName(SuiteVisitor):  # type: ignore
+class ByLongName(SuiteVisitor):
     def __init__(self, *included: str) -> None:
         super().__init__()
         self.included = included
@@ -26,7 +26,7 @@ def end_suite(self, suite: TestSuite) -> None:
         suite.suites = [s for s in suite.suites if s.test_count > 0]
 
 
-class ExcludedByLongName(SuiteVisitor):  # type: ignore
+class ExcludedByLongName(SuiteVisitor):
     def __init__(self, *included: str) -> None:
         super().__init__()
         self.included = included

robotcode/debugger/modifiers/longname_modifiers.py

@@ -158,16 +158,25 @@ def start_tcp(self, host: Optional[str] = None, port: int = 0) -> None:
 
     @_logger.call
     def start_pipe(self, pipe_name: Optional[str]) -> None:
+        from typing import TYPE_CHECKING
+
+        if TYPE_CHECKING:
+            from asyncio.streams import StreamReaderProtocol
+            from asyncio.windows_events import ProactorEventLoop
+
         if pipe_name is None:
             raise ValueError("pipe name missing.")
 
         self.mode = JsonRpcServerMode.PIPE
 
         try:
+            #  check if we are on windows and using the ProactorEventLoop, to use the undocumented
+            #  create_pipe_connection method
             if sys.platform == "win32" and hasattr(self.loop, "create_pipe_connection"):
-                # this is a proactor event loop and we can use the not documented method create_pipe_connection
                 self.loop.run_until_complete(
-                    self.loop.create_pipe_connection(self.create_protocol, pipe_name),  # type: ignore
+                    cast("ProactorEventLoop", self.loop).create_pipe_connection(
+                        lambda: cast("StreamReaderProtocol", self.create_protocol()), pipe_name
+                    ),
                 )
             else:
                 self.loop.run_until_complete(self.loop.create_unix_connection(self.create_protocol, pipe_name))

robotcode/jsonrpc2/server.py

@@ -575,7 +575,7 @@ async def get_libdoc_from_model(
 
         ResourceBuilder(res).visit(model)
 
-        class MyUserLibrary(UserLibrary):  # type: ignore
+        class MyUserLibrary(UserLibrary):
             current_kw: Any = None
 
             def _log_creating_failed(self, handler: UserErrorHandler, error: BaseException) -> None:

robotcode/language_server/robotframework/diagnostics/imports_manager.py

@@ -981,7 +981,7 @@ def get_library_doc(
     from robot.running.testlibraries import _get_lib_class
     from robot.utils import Importer
 
-    class Logger(AbstractLogger):  # type: ignore
+    class Logger(AbstractLogger):
         def __init__(self) -> None:
             super().__init__()
             self.messages: List[Tuple[str, str, bool]] = []

robotcode/language_server/robotframework/diagnostics/library_doc.py

@@ -100,7 +100,7 @@ async def collect(
             if extension_config.configurations:
                 config.configure = set(extension_config.configurations)
 
-            class MyRobocop(Robocop):  # type: ignore
+            class MyRobocop(Robocop):
                 async def run_check(self, ast_model, filename, source=None):  # type: ignore
                     await check_canceled()